Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mjml-react home #2639

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update mjml-react home #2639

merged 1 commit into from
Feb 22, 2023

Conversation

IanEdington
Copy link
Contributor

@IanEdington IanEdington commented Feb 22, 2023

Faire has taken over maintenance of mjml-react and has it in a stable state

v2 = perfect replica of https://github.com/wix-incubator/mjml-react
v3 = minor improvements on v2 that help with maintainability and types (LTS)
v4.beta = new features

cc: @daliusd (from https://github.com/wix-incubator/mjml-react)

@daliusd
Copy link

daliusd commented Feb 22, 2023

I can confirm that @IanEdington is right. BTW, @IanEdington are you using Vim/Neovim?

@iRyusa iRyusa merged commit d97e579 into mjmlio:master Feb 22, 2023
@IanEdington
Copy link
Contributor Author

@daliusd yes I use vim pretty regularly. Why do you ask?

@daliusd
Copy link

daliusd commented Feb 22, 2023

@daliusd yes I use vim pretty regularly. Why do you ask?

I have noticed this in your commit:
image

You can avoid this by setting fixeol to false.

@IanEdington IanEdington deleted the patch-2 branch February 22, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants