Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental support for glasflow flows #386

Merged
merged 12 commits into from
May 16, 2024
Merged

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented May 8, 2024

This PR adds experimental support for using flows from glasflow directly.

I've implemented a wrapper that can be used with any of the classes from glasflow and translates the positional arguments.

This should enable us to use new flows in glasflow directly without having to implement them in nessai. Long term, this might also enable us to remove the native flows from nessai entirely.

For now, I've excluded the experimental submodule from the coverage so we can add things there without having to worry about having a complete suite of tests. This should also make it clear these features are experimental and may change.

@mj-will mj-will added enhancement New feature or request experimental labels May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (b622fd0) to head (bf20c41).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   93.65%   93.69%   +0.03%     
==========================================
  Files          67       67              
  Lines        6554     6563       +9     
==========================================
+ Hits         6138     6149      +11     
+ Misses        416      414       -2     
Flag Coverage Δ
unittests 93.69% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mj-will mj-will force-pushed the support-glasflow-flows branch from 83f06e4 to 596eee9 Compare May 14, 2024 13:18
@mj-will mj-will marked this pull request as ready for review May 16, 2024 12:51
@mj-will mj-will merged commit 16b5ee6 into main May 16, 2024
36 checks passed
@mj-will mj-will added this to the v0.13.0 milestone Jul 23, 2024
@mj-will mj-will deleted the support-glasflow-flows branch August 8, 2024 09:45
@mj-will mj-will mentioned this pull request Aug 13, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant