Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using large runners #1269

Merged
merged 2 commits into from
Mar 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/test-mitosheet-frontend.yml
Original file line number Diff line number Diff line change
@@ -119,7 +119,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
os: ['ubuntu-latest-m', 'macos-latest', 'windows-latest-l']
python-version: ['3.10']
project:
- test-name: 'chromium'
@@ -134,16 +134,16 @@ jobs:
install-name: 'msedge'
testfiles: ['taskpanes', 'grid', 'toolbar', 'graph']
exclude:
- os: 'windows-latest'
- os: 'windows-latest-l'
project:
test-name: webkit
- os: 'macos-latest'
project:
test-name: 'Microsoft Edge'
- os: 'ubuntu-latest'
- os: 'ubuntu-latest-m'
project:
test-name: 'Microsoft Edge'
- os: 'ubuntu-latest'
- os: 'ubuntu-latest-m'
project:
test-name: 'webkit'
fail-fast: false
@@ -167,20 +167,20 @@ jobs:
cache: 'npm'
cache-dependency-path: mitosheet/package-lock.json
- name: Install dependencies (ubuntu, macos)
if: matrix.os != 'windows-latest'
if: matrix.os != 'windows-latest-l'
run: |
cd tests
bash mac-setup.sh ${{ matrix.project.install-name }}
source venv/bin/activate
pip install -r extra-requirements.txt
- name: Setup streamlit (ubuntu, macos)
if: matrix.os != 'windows-latest'
if: matrix.os != 'windows-latest-l'
run: |
mkdir -p ~/.streamlit/
echo "[general]" > ~/.streamlit/credentials.toml
echo "email = \"\"" >> ~/.streamlit/credentials.toml
- name: Setup streamlit (windows)
if: matrix.os == 'windows-latest'
if: matrix.os == 'windows-latest-l'
run: |
$streamlitDir = "$HOME\.streamlit"
if (-not (Test-Path -Path $streamlitDir)) {
@@ -191,7 +191,7 @@ jobs:
email = ""
"@
- name: Install dependencies (windows)
if: matrix.os == 'windows-latest'
if: matrix.os == 'windows-latest-l'
run: |
cd tests

@@ -210,15 +210,15 @@ jobs:
npm install
npm run build
- name: Start a server and run tests (ubuntu, macos)
if: matrix.os != 'windows-latest'
if: matrix.os != 'windows-latest-l'
run: |
cd tests
source venv/bin/activate
streamlit run streamlit_test.py --server.port 8555 &
bash check_server.sh
npm run test -- --project="${{ matrix.project.test-name }}" streamlit_ui_tests/${{matrix.testfiles}}
- name: Start a server and run tests (windows)
if: matrix.os == 'windows-latest'
if: matrix.os == 'windows-latest-l'
run: |
cd tests
.\venv\Scripts\Activate.ps1
2 changes: 1 addition & 1 deletion mitosheet/src/mito/Mito.tsx
Original file line number Diff line number Diff line change
@@ -66,6 +66,7 @@ import { classNames } from './utils/classNames';
import loadPlotly from './utils/plotly';
// AUTOGENERATED LINE: MITOIMPORT (DO NOT DELETE)
import { isInJupyterLab, isInJupyterNotebook } from '.';
import { MitoAPIResult } from './api/api';
import { SendFunction, SendFunctionError } from './api/send';
import BottomLeftPopup from './components/elements/BottomLeftPopup';
import StreamlitSignupModal from './components/modals/StreamlitSignupModal';
@@ -85,7 +86,6 @@ import { getCSSStyleVariables } from './utils/colors';
import { handleKeyboardShortcuts } from './utils/keyboardShortcuts';
import { isInDashboard } from './utils/location';
import { shallowEqualToDepth } from './utils/objects';
import { MitoAPIResult } from './api/api';

export type MitoProps = {
getSendFunction: () => Promise<SendFunction | SendFunctionError>
Loading