Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column control panel tests #1235

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Add column control panel tests #1235

merged 5 commits into from
Mar 5, 2024

Conversation

marthacryan
Copy link
Contributor

Adds tests for:

  • Changing column dtype
  • Adding a filter
  • Sorting
  • Changing the number type
  • Filtering values through the values tab
  • Loading summary stats

Adds utilities for:

  • opening the column control panel
  • changing the dtype
  • changing the number type
  • checking that column cells have expected values
  • checking the control panel's value tab has expected values

@vercel Vercel
Copy link

vercel bot commented Mar 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 6:06pm

aarondr77
aarondr77 reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@aarondr77 aarondr77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super lovely. A few more test ideas and then LGTM

tests/streamlit_ui_tests/features/column_control_panel.spec.ts
}
}

const checkValuesTabHasExpectedValues = async (mito: FrameLocator, expectedValues: any[]) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have a utility for this in the merge tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I see?

@marthacryan marthacryan merged commit d13ad63 into dev Mar 5, 2024
40 of 41 checks passed
@marthacryan marthacryan deleted the column-control-panel-tests branch March 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarondr77 aarondr77 aarondr77 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marthacryan @aarondr77