Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: unclip #8823

Merged
merged 11 commits into from
Jun 18, 2022
Merged

Improve: unclip #8823

merged 11 commits into from
Jun 18, 2022

Conversation

futchitwo
Copy link
Contributor

What

  • ノートをクリップから除外するAPI作成
  • クリップ済みのノートをもう一度クリップしようとするとクリップ解除のダイアログが出るように
  • 自分のクリップのページを開いているときにノートメニューにクリップ解除の項目を追加

実装していないもの

  • クリップ解除モード
  • ノートメニューのクリップ一覧で、ノートがクリップに含まれているかを確認できる機能

Why

Additional info (optional)

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels Jun 12, 2022
@Johann150
Copy link
Contributor

I think we should review #8822 first to avoid duplicate review of the first commits (until & including d9e5992)

@syuilo syuilo merged commit 5b7595d into misskey-dev:develop Jun 18, 2022
@syuilo
Copy link
Member

syuilo commented Jun 18, 2022

👍🏻 👍🏻

Jeder321 pushed a commit to Jeder321/misskey that referenced this pull request Jul 13, 2022
* Refactor clip page to use Composition API

* Refactor clip page

* Refactor clip page

* Refactor clip page

* Improve: unclip

* Fix unclip

* Fix unclip

* chore: better type and name

* Fix

* Fix clipPage vue provider

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
@futchitwo futchitwo deleted the clip-remove-rebase branch July 16, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

クリップの解除ができない
3 participants