Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 現在のカラーモードにかかわらずライト/ダーク両方のテーマ設定を変更できるように #15649

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Mar 11, 2025

What

  • 現在のカラーモードではないほうのFolderを完全に隠さないようにした
    • 設定の検索には出るのに設定項目が無いということがないように
    • カラーモードにかかわらず両方のテーマ設定を変更できる(利便性向上)
  • 代わりに、ページ読み込み時点でのカラーモードをもとにdefaultOpenを決定するように
    現在ライトモードならライトモードのテーマ切り替えがはじめから開いており、ダークモードのテーマ切り替えは閉じている…という状態にする

Why

UI改善

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 130 lines in your changes missing coverage. Please review.

Project coverage is 15.32%. Comparing base (d185785) to head (56df878).

Files with missing lines Patch % Lines
packages/frontend/src/pages/settings/theme.vue 0.00% 127 Missing ⚠️
...ntend/src/utility/autogen/settings-search-index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15649       +/-   ##
============================================
- Coverage    41.87%   15.32%   -26.55%     
============================================
  Files         1625      787      -838     
  Lines       166074    72387    -93687     
  Branches      4108     1279     -2829     
============================================
- Hits         69537    11095    -58442     
+ Misses       96093    60867    -35226     
+ Partials       444      425       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syuilo
Copy link
Member

syuilo commented Mar 12, 2025

現在のモードではない方のテーマを(見た目を確認することもなく)選択したいことは無い気がするわね

@syuilo
Copy link
Member

syuilo commented Mar 12, 2025

設定項目がなくても現在のモードと異なっているために設定が不可になっているということは理解できそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants