-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(frontend): CWの注釈テキストが入力されていない場合はPostボタンを非アクティブに #15639
base: develop
Are you sure you want to change the base?
enhance(frontend): CWの注釈テキストが入力されていない場合はPostボタンを非アクティブに #15639
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15639 +/- ##
============================================
- Coverage 41.95% 15.38% -26.58%
============================================
Files 1623 785 -838
Lines 165777 72086 -93691
Branches 4119 1278 -2841
============================================
- Hits 69558 11088 -58470
+ Misses 95742 60574 -35168
+ Partials 477 424 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issueの本題からは逸れるものですが、(個人的には)逆にこの行だけを条件式から外したままにするほうが違和感を感じるので、一旦含めた形にしました。 |
この変更で(おそらく) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI上投稿できないことが明確になってわかりやすくなりそうです
コードの変更も良さそうに思います
i18nに関しては消してもいいし、CWがないときにはフォームにチュートリアルが出る仕様などにするのもよいかもしれませんが一旦このままでも個人的にはいいと思います
What
Why
Resolve #14151
Additional info (optional)
Checklist