Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): pnpm v10でre2のインストールに失敗することがある問題を修正 #15627

Merged
merged 4 commits into from
Mar 8, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Mar 8, 2025

What

uhop/node-re2#221
renovatebot/renovate#34397

re2を自力ビルドできる環境が揃っていない環境でpnpm iすると、インストールに失敗する問題を修正
(インストールスクリプトで環境変数が渡せないようになり、ビルド済みのre2をダウンロードできなくなっていたことによる)

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih
Copy link
Contributor Author

Windowsでは動作しない

@kakkokari-gtyih
Copy link
Contributor Author

Windowsでは動作しない

するようになった

@syuilo syuilo merged commit e16a14d into misskey-dev:develop Mar 8, 2025
7 checks passed
@syuilo
Copy link
Member

syuilo commented Mar 8, 2025

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-re2-pnpm branch March 8, 2025 09:57
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Mar 8, 2025
* fix(deps): pnpm v10でre2のインストールに失敗することがある問題を修正

* fix

* fix docker build

* fix build failure on Windows
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 8, 2025
* fix(deps): pnpm v10でre2のインストールに失敗することがある問題を修正

* fix

* fix docker build

* fix build failure on Windows
harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Mar 8, 2025
* fix(deps): pnpm v10でre2のインストールに失敗することがある問題を修正

* fix

* fix docker build

* fix build failure on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants