Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update pnpm to v10 #15588

Merged
merged 26 commits into from
Mar 7, 2025
Merged

deps: update pnpm to v10 #15588

merged 26 commits into from
Mar 7, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Mar 3, 2025 •
edited
Loading

What

  • corepackを削除
  • pnpmをv10に上げる
  • パッケージのバージョン指定をデフォルトで特定のバージョンに固定するように

Why

Fix #14533

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Mar 3, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.55%. Comparing base (d49ecab) to head (f722342).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/server/ActivityPubServerService.ts 0.00% 1 Missing ⚠️
packages/backend/src/server/FileServerService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #15588      +/-   ##
===========================================
+ Coverage    41.58%   43.55%   +1.97%     
===========================================
  Files         1617     1621       +4     
  Lines       165039   170878    +5839     
  Branches      4074     4138      +64     
===========================================
+ Hits         68631    74427    +5796     
- Misses       95966    95975       +9     
- Partials       442      476      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025 •
edited
Loading

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@tamaina
Copy link
Contributor

tamaina commented Mar 3, 2025

Resolves #14533 ?

@kakkokari-gtyih
Copy link
Contributor Author

ready

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review March 3, 2025 12:07
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.3.0 milestone Mar 3, 2025
anatawa12
anatawa12 reviewed Mar 3, 2025
View reviewed changes
anatawa12
anatawa12 reviewed Mar 3, 2025
View reviewed changes
@kakkokari-gtyih kakkokari-gtyih modified the milestones: v2025.3.0, v2025.3.1 Mar 5, 2025
@kakkokari-gtyih kakkokari-gtyih modified the milestones: v2025.3.1, v2025.3.2 Mar 7, 2025
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

anatawa12
anatawa12 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storybookはcorepack@0.31以降になってないのが原因で、このPRでcorepack依存が消えたので無視してＯＫ

@mi-gh-maintainer mi-gh-maintainer bot merged commit 83c3bb8 into misskey-dev:develop Mar 7, 2025
33 of 34 checks passed
@mi-gh-maintainer mi-gh-maintainer
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the deps-update-pnpm branch March 7, 2025 10:10
4ster1sk added a commit to 4ster1sk/misskey that referenced this pull request Mar 7, 2025
@4ster1sk
Revert "deps: update pnpm to v10 (misskey-dev#15588)"
9acd8a9 
This reverts commit 83c3bb8.
@samunohito samunohito mentioned this pull request Mar 8, 2025
Merged
5 tasks
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 8, 2025
@kakkokari-gtyih @DA-TENSHI
deps: update pnpm to v10 (misskey-dev#15588)
35b5bde 
* Revert "fix(build): corepackのバグの回避 (misskey-dev#15387)"

This reverts commit 9c70a4e.

* deps: update pnpm to v10

* fix broken lockfile

* update changelog

* fix

* fix

* Revert "fix"

This reverts commit 4abc6c1.

* fix

* fix

* attempt to fix docker build

* lint fixes

* fix: revertしすぎた

* detect pnpm version and install it

* fix: そもそもpnpmを2回入れる必要がないかも

* fix

* refactor

* fix

* refactor: remove unnecessary arg

* Update Dockerfile

* update pnpm to v10.6.1

* Update Changelog

* chore: use node to avoid installing jq
harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Mar 8, 2025
@kakkokari-gtyih @harumaki2000
deps: update pnpm to v10 (misskey-dev#15588)
ca1196e 
* Revert "fix(build): corepackのバグの回避 (misskey-dev#15387)"

This reverts commit 9c70a4e.

* deps: update pnpm to v10

* fix broken lockfile

* update changelog

* fix

* fix

* Revert "fix"

This reverts commit 4abc6c1.

* fix

* fix

* attempt to fix docker build

* lint fixes

* fix: revertしすぎた

* detect pnpm version and install it

* fix: そもそもpnpmを2回入れる必要がないかも

* fix

* refactor

* fix

* refactor: remove unnecessary arg

* Update Dockerfile

* update pnpm to v10.6.1

* Update Changelog

* chore: use node to avoid installing jq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatawa12 anatawa12 anatawa12 approved these changes

Assignees
No one assigned
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
[実験中] 管理用
Status: Done
Milestone
v2025.3.1
Development

Successfully merging this pull request may close these issues.

node24: corepack being removed in next major release
3 participants
@kakkokari-gtyih @tamaina @anatawa12