Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): prevent deadlock #15574

Merged
merged 1 commit into from
Mar 1, 2025
Merged

fix(backend): prevent deadlock #15574

merged 1 commit into from
Mar 1, 2025

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Mar 1, 2025

What

fix #15005

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Mar 1, 2025
@syuilo syuilo marked this pull request as ready for review March 1, 2025 05:34
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.16%. Comparing base (830da5e) to head (f3652b1).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...end/src/core/activitypub/models/ApPersonService.ts 25.00% 3 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15574       +/-   ##
============================================
+ Coverage    14.66%   42.16%   +27.50%     
============================================
  Files          771     1609      +838     
  Lines        68851   162370    +93519     
  Branches      1237     4060     +2823     
============================================
+ Hits         10095    68459    +58364     
- Misses       58336    93472    +35136     
- Partials       420      439       +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 1, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

#15005

Co-Authored-By: 饺子w (Yumechi) <35571479+eternal-flame-AD@users.noreply.github.com>
@syuilo syuilo merged commit 5d68372 into develop Mar 1, 2025
32 checks passed
@syuilo syuilo deleted the prevent-deadlock branch March 1, 2025 07:12
harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Mar 2, 2025
misskey-dev#15005

Co-authored-by: 饺子w (Yumechi) <35571479+eternal-flame-AD@users.noreply.github.com>
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 6, 2025
misskey-dev#15005

Co-authored-by: 饺子w (Yumechi) <35571479+eternal-flame-AD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

Data race leading to Multiple Database deadlocks processing 'Delete' Activity
1 participant