Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 表示される広告の選定条件を変更 #15572

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Mar 1, 2025

What

  • squareの出る箇所が少ない問題を修正(squareを入れてもデザイン的に支障がない部分にsquareを追加)
  • 選定条件を変更

Why

Fix #15568

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

kakkokari-gtyih and others added 2 commits March 1, 2025 12:29
Co-Authored-By: あわわわとーにゅ <17376330+u1-liquid@users.noreply.github.com>
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 1, 2025
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 14.28%. Comparing base (d7706ef) to head (d07d36d).

Files with missing lines Patch % Lines
...es/frontend/src/components/MkDateSeparatedList.vue 0.00% 1 Missing ⚠️
packages/frontend/src/pages/flash/flash.vue 0.00% 1 Missing ⚠️
packages/frontend/src/pages/gallery/post.vue 0.00% 1 Missing ⚠️
packages/frontend/src/pages/page.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15572       +/-   ##
============================================
- Coverage    40.31%   14.28%   -26.04%     
============================================
  Files         1617      779      -838     
  Lines       165039    71371    -93668     
  Branches      3753     1243     -2510     
============================================
- Hits         66532    10192    -56340     
+ Misses       98025    60756    -37269     
+ Partials       482      423       -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

広告登録時の偏りについて
1 participant