enhance(frontend): ノートに埋め込まれたメディアのコンテキストメニューから管理者用のファイル管理画面を開けるように #15460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15460 +/- ##
===========================================
+ Coverage 18.83% 18.84% +0.01%
===========================================
Files 768 768
Lines 111570 111606 +36
Branches 1236 1236
===========================================
+ Hits 21013 21037 +24
- Misses 89966 89978 +12
Partials 591 591 ☔ View full report in Codecov by Sentry. |
kakkokari-gtyih
approved these changes
Feb 11, 2025
|
アイコンがti-pencilなのがちょっとミスマッチ感あるかも |
|
（言われて初めて気が付いた） |
syuilo
reviewed
Feb 13, 2025
Comment on lines
233
to
234
| text: i18n.ts._fileViewer.titleAdmin, | ||
| icon: 'ti ti-info-circle', |
There was a problem hiding this comment.
ユーザーのメニューと揃えて
Suggested change
| text: i18n.ts._fileViewer.titleAdmin, | |
| icon: 'ti ti-info-circle', | |
| text: i18n.ts.moderation, | |
| icon: 'ti ti-photo-exclamation', |
でよさそう
|
Thank you 🙏 |
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Feb 13, 2025
…isskey-dev#15460) * enhance(frontend): ノートに埋め込まれたメディアのコンテキストメニューから管理者用のファイル管理画面を開けるように * fix icon * fix menu --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Mar 1, 2025
…isskey-dev#15460) * enhance(frontend): ノートに埋め込まれたメディアのコンテキストメニューから管理者用のファイル管理画面を開けるように * fix icon * fix menu --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
タイトルの通りです。
ノートに埋め込まれた画像、動画、音声のメニューから管理者用のファイル管理画面を開けるようにします（モデレーター権限以上のみ）
Why
fix #15440
Additional info (optional)
ローカルで実際に動作確認済み
Checklist