Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): コンディショナルロールを手動で割り当てできる導線を削除 #15436

Merged

Conversation

samunohito
Copy link
Member

What

admin/user/[userId]の画面からロールをアサインする際、コンディショナルロールが選択肢として表示されてしまっていたのを塞ぎました。

Why

fix #13529

コンディショナルロールはシステムにより自動判定されて割り当てられるロールなので、手動割り当ては意図とそぐわないため

Additional info (optional)

実際に動作確認済み

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 9, 2025
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.83%. Comparing base (420365c) to head (f336cfa).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin-user.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #15436   +/-   ##
========================================
  Coverage    18.83%   18.83%           
========================================
  Files          768      768           
  Lines       111555   111555           
  Branches      1236     1236           
========================================
  Hits         21013    21013           
  Misses       89951    89951           
  Partials       591      591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit a1ca68a into misskey-dev:develop Feb 11, 2025
9 checks passed
Copy link

Thank you 🙏

DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Feb 11, 2025
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

条件付きロールを手動で割り当てた場合、キャンセルはできません
3 participants