Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ユーザのサジェスト中に@を入力してもサジェスト結果が消えないように #15435

Conversation

samunohito
Copy link
Member

What

タイトルの通りです。
リモートユーザのサジェスト中に@が入力されると絞り込み結果が0件になってしまうのを解消しました。

Why

fix #14385

Additional info (optional)

実際に動作確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 9, 2025
@samunohito samunohito marked this pull request as ready for review February 9, 2025 09:21
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 14.61%. Comparing base (495db27) to head (4adf77a).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/autocomplete.ts 0.00% 6 Missing ⚠️
...ackages/frontend/src/components/MkAutocomplete.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15435       +/-   ##
============================================
- Coverage    40.90%   14.61%   -26.29%     
============================================
  Files         1610      771      -839     
  Lines       162151    68626    -93525     
  Branches      3744     1234     -2510     
============================================
- Hits         66321    10029    -56292     
+ Misses       95355    58177    -37178     
+ Partials       475      420       -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 11, 2025
@mi-gh-maintainer mi-gh-maintainer bot merged commit d87488a into misskey-dev:develop Feb 26, 2025
8 of 9 checks passed
Copy link

Thank you 🙏

harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 26, 2025
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Mar 1, 2025
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Mar 1, 2025
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
3 participants