-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): カスタム絵文字の一括インポートをした時にHTTPプロキシの除外設定が効かないのを修正 #15431
Merged
mi-gh-maintainer
merged 6 commits into
misskey-dev:develop
from
samunohito:fix/download-proxy
Feb 26, 2025
Merged
fix(backend): カスタム絵文字の一括インポートをした時にHTTPプロキシの除外設定が効かないのを修正 #15431
mi-gh-maintainer
merged 6 commits into
misskey-dev:develop
from
samunohito:fix/download-proxy
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
このPRによるapi.jsonの差分 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15431 +/- ##
===========================================
- Coverage 42.18% 42.16% -0.02%
===========================================
Files 1610 1610
Lines 162118 162151 +33
Branches 4057 4043 -14
===========================================
- Hits 68387 68370 -17
- Misses 93292 93308 +16
- Partials 439 473 +34 ☔ View full report in Codecov by Sentry. |
Thank you 🙏 |
harumaki2000
pushed a commit
to harumaki2000/misskey-layp
that referenced
this pull request
Feb 26, 2025
…#15431) * pxory * fix * fix CHANGELOG.md * allow localAddress --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Mar 1, 2025
…#15431) * pxory * fix * fix CHANGELOG.md * allow localAddress --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Mar 6, 2025
…#15431) * pxory * fix * fix CHANGELOG.md * allow localAddress --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
DownloadServiceによるファイル取得時に、HTTPプロキシの除外設定に従って適切なhttpAgent/httpsAgentを使用するようにしました。
Why
fix #8766
Additional info (optional)
元issueのSteps to Reproduceどおりに操作して問題の発生を確認
↓
修正後のソースで同じ手順で捜査してインポートが動作するのを確認
Checklist