Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): clips/updateのdescriptionで空文字を許容するように #15429

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Feb 8, 2025

What

Why

Fix #15419

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 8, 2025
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -30467,7 +30467,6 @@
                       "string",
                       "null"
                     ],
-                    "minLength": 1,
                     "maxLength": 2048
                   }
                 },
@@ -31925,7 +31924,6 @@
                       "string",
                       "null"
                     ],
-                    "minLength": 1,
                     "maxLength": 2048
                   }
                 },

Get diff files from Workflow Page

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.15%. Comparing base (389ec63) to head (7e7ffba).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...s/backend/src/server/api/endpoints/clips/create.ts 25.00% 3 Missing ⚠️
...s/backend/src/server/api/endpoints/clips/update.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15429      +/-   ##
===========================================
- Coverage    42.18%   42.15%   -0.03%     
===========================================
  Files         1610     1610              
  Lines       162112   162116       +4     
  Branches      4055     4037      -18     
===========================================
- Hits         68383    68348      -35     
- Misses       93259    93329      +70     
+ Partials       470      439      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@mi-gh-maintainer mi-gh-maintainer bot merged commit b579935 into misskey-dev:develop Feb 26, 2025
18 checks passed
Copy link

Thank you 🙏

harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 26, 2025
* fix(backend): clips/updateのdescriptionで空文字を許容するように

* Update Changelog

* fix: createの際も空文字を許容するように

* fix test

* fix test

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
@kakkokari-gtyih kakkokari-gtyih deleted the fix-14519 branch February 26, 2025 12:57
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Mar 1, 2025
* fix(backend): clips/updateのdescriptionで空文字を許容するように

* Update Changelog

* fix: createの際も空文字を許容するように

* fix test

* fix test

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Mar 1, 2025
* fix(backend): clips/updateのdescriptionで空文字を許容するように

* Update Changelog

* fix: createの際も空文字を許容するように

* fix test

* fix test

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 6, 2025
* fix(backend): clips/updateのdescriptionで空文字を許容するように

* Update Changelog

* fix: createの際も空文字を許容するように

* fix test

* fix test

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

クリップの説明欄を空に戻すことができない
3 participants