-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): リノート経由でノートの詳細情報を見るとき、クリップ一覧がappearNoteのものになるように #15417
Merged
mi-gh-maintainer
merged 4 commits into
misskey-dev:develop
from
kakkokari-gtyih:fix-inconsistent-clip-info
Feb 26, 2025
Merged
fix(frontend): リノート経由でノートの詳細情報を見るとき、クリップ一覧がappearNoteのものになるように #15417
mi-gh-maintainer
merged 4 commits into
misskey-dev:develop
from
kakkokari-gtyih:fix-inconsistent-clip-info
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15417 +/- ##
============================================
- Coverage 42.18% 14.61% -27.57%
============================================
Files 1610 771 -839
Lines 162156 68628 -93528
Branches 4059 1235 -2824
============================================
- Hits 68401 10029 -58372
+ Misses 93316 58179 -35137
+ Partials 439 420 -19 ☔ View full report in Codecov by Sentry. |
Thank you 🙏 |
harumaki2000
pushed a commit
to harumaki2000/misskey-layp
that referenced
this pull request
Feb 27, 2025
…ey-dev#15417) * fix(frontend): リノート経由でノートの詳細情報を見るとき、クリップ一覧がappearNoteのものになるように * Update Changelog --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Mar 1, 2025
…ey-dev#15417) * fix(frontend): リノート経由でノートの詳細情報を見るとき、クリップ一覧がappearNoteのものになるように * Update Changelog --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Mar 6, 2025
…ey-dev#15417) * fix(frontend): リノート経由でノートの詳細情報を見るとき、クリップ一覧がappearNoteのものになるように * Update Changelog --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
↑ここのクリップ一覧がappearNoteをもとに取得されるように
各種メニューから利用できる操作は全てappearNoteのものなので、クリップ一覧もappearNoteで取得したほうが良さそう
Why
見かけ上クリップ一覧が表示されない(=実際はリノートがクリップに含まれているかどうかを問い合わせているだけ)ことがある問題を修正
Additional info (optional)
Checklist