fix(dev): devcontainerのcorepackのバージョンを指定するように #15415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
approved these changes
Feb 7, 2025
KisaragiEffective
approved these changes
Feb 8, 2025
|
Thank you 🙏 |
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Feb 8, 2025
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
devcontainer.jsonでcorepackのバージョンを0.31.0に指定ghcr.io/devcontainers-extra/features/corepackに変更Why
close #15412
Additional info (optional)
ghcr.io/devcontainers-contrib/features/corepackはリポジトリがアーカイブされているため、後継と思しきghcr.io/devcontainers-extra/features/corepackを使用したほうがいいと思われます。init.shにexport COREPACK_DEFAULT_TO_LATEST=0を指定してもcorepackのインストールはdevcontainer.jsonのfeaturesで行うため意味がありませんでしたChecklist