Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): クライアントエラー画面の多言語対応 #15411

Merged
merged 5 commits into from
Feb 8, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Feb 7, 2025

What

image

localStorage langsに言語が在る場合はそれを使用して多言語対応
メッセージが無い場合は英語にフォールバック

Why

Fix #13472

Additional info (optional)

サーバーエラーはswを経由したほうが良さそうだけど実装が複雑化しそうなので一旦見送り

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.67%. Comparing base (607bf60) to head (3a5ab75).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15411       +/-   ##
============================================
+ Coverage    18.82%   38.67%   +19.85%     
============================================
  Files          766     1605      +839     
  Lines       111400   204658    +93258     
  Branches      1234     4029     +2795     
============================================
+ Hits         20966    79158    +58192     
- Misses       89845   124892    +35047     
- Partials       589      608       +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 7, 2025
@mi-gh-maintainer mi-gh-maintainer bot merged commit 4b98b44 into misskey-dev:develop Feb 8, 2025
34 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the enh-13472 branch February 8, 2025 08:33
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Mar 1, 2025
* enhance(frontend): クライアントエラー画面のマルチリンガル対応

* Update Changelog

* update message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

Make the error page translatable so it can be localized
1 participant