-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: アンテナでセンシティブなチャンネルからのノートを除外できるように #15346
base: develop
Are you sure you want to change the base?
feat: アンテナでセンシティブなチャンネルからのノートを除外できるように #15346
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15346 +/- ##
============================================
+ Coverage 15.34% 43.88% +28.54%
============================================
Files 785 1627 +842
Lines 72098 171634 +99536
Branches 1279 4143 +2864
============================================
+ Hits 11066 75328 +64262
- Misses 60608 95829 +35221
- Partials 424 477 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -18560,6 +18560,9 @@
},
"withFile": {
"type": "boolean"
+ },
+ "hideNotesInSensitiveChannel": {
+ "type": "boolean"
}
},
"required": [
@@ -19461,6 +19464,9 @@
},
"withFile": {
"type": "boolean"
+ },
+ "hideNotesInSensitiveChannel": {
+ "type": "boolean"
}
},
"required": [
@@ -81884,6 +81890,10 @@
"notify": {
"type": "boolean",
"default": false
+ },
+ "hideNotesInSensitiveChannel": {
+ "type": "boolean",
+ "default": false
}
},
"required": [
@@ -81902,7 +81912,8 @@
"withFile",
"isActive",
"hasUnreadNote",
- "notify"
+ "notify",
+ "hideNotesInSensitiveChannel"
]
},
"Clip": { |
@@ -626,6 +629,42 @@ describe('アンテナ', () => { | |||
assert.deepStrictEqual(response, expected); | |||
}); | |||
|
|||
test('が取得できること(センシティブチャンネルのノートを除く)', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これだけチャンネル作成が必要になってくるので上のeachとは別に書いています。
d8c380a
to
f98076e
Compare
そういえば:このPRってどういう状況なんでしょうか?(次のMisskey Office Hour待ちみたいな感じとか?) |
明日レビューします! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一通り見ましたが、明日の朝にもう一回見たいので見ます
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
CHANGELOGをUnreleasedのところに移動しました。よろしくお願いします。 |
(このPRってどういう状態なんでしょう?) |
他に緊急度の高い問題があり、優先度の兼ね合いからマージ待ちのままになっています。 |
What
タイトル通りです。
Why
closes: #14177
Additional info (optional)
手元の環境ではなぜかESLintのフォーマットが効かなかったので手動フォーマットしています。(おそらく何か間違えている...)
Checklist