feat(frontend): 画像を投稿前にプレビュー可能に #15341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15341 +/- ##
============================================
- Coverage 38.77% 18.82% -19.96%
============================================
Files 1601 766 -835
Lines 203902 111137 -92765
Branches 4011 1235 -2776
============================================
- Hits 79065 20919 -58146
+ Misses 124201 89629 -34572
+ Partials 636 589 -47 ☔ View full report in Codecov by Sentry. |
Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com>
|
Storybookも上げたので最新の背景はChromaticで |
kakkokari-gtyih
approved these changes
Jan 25, 2025
|
一応Chromaticから転載もしておきます |
tai-cha
commented
Jan 27, 2025
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Jan 28, 2025
commit 83d2794 Author: taichan <40626578+tai-cha@users.noreply.github.com> Date: Mon Jan 27 10:23:18 2025 +0900 Update packages/frontend/.storybook/generate.tsx commit 842c745 Author: tai-cha <dev@taichan.site> Date: Sat Jan 25 17:09:01 2025 +0900 Add MkImgPreviewDialog to storybook generator commit e1365fb Author: tai-cha <dev@taichan.site> Date: Sat Jan 25 17:02:37 2025 +0900 backgroundのスタイル変更 Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> commit 4bb30a1 Author: tai-cha <dev@taichan.site> Date: Sat Jan 25 16:59:32 2025 +0900 Add storybook for MkImgPreviewDialog commit c838f80 Author: tai-cha <dev@taichan.site> Date: Sat Jan 25 16:43:25 2025 +0900 消えてたのFix commit b4842c0 Author: tai-cha <dev@taichan.site> Date: Sat Jan 25 16:41:09 2025 +0900 SPDX commit 5b0aec5 Author: tai-cha <dev@taichan.site> Date: Sat Jan 25 16:33:33 2025 +0900 Update Changelog commit ce787e4 Author: tai-cha <dev@taichan.site> Date: Sat Jan 25 16:31:51 2025 +0900 feat(client): 画像をプレビュー可能に
5 tasks
noridev
added a commit
to kokonect-link/cherrypick
that referenced
this pull request
Feb 6, 2025
mi-gh-maintainer
bot
merged commit 2f8d020
into
misskey-dev:develop
22 of 23 checks passed
|
Thank you 🙏 |
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Feb 8, 2025
* feat(client): 画像をプレビュー可能に * Update Changelog * SPDX * 消えてたのFix * Add storybook for MkImgPreviewDialog * backgroundのスタイル変更 Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> * Add MkImgPreviewDialog to storybook generator * Update packages/frontend/.storybook/generate.tsx --------- Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com>
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Mar 1, 2025
* feat(client): 画像をプレビュー可能に * Update Changelog * SPDX * 消えてたのFix * Add storybook for MkImgPreviewDialog * backgroundのスタイル変更 Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> * Add MkImgPreviewDialog to storybook generator * Update packages/frontend/.storybook/generate.tsx --------- Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
投稿フォームに画像のプレビューを追加
Why
Close #15247
Additional info (optional)
Checklist