Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): verbatimModuleSyntaxを有効化 #15323

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 21, 2025

What

frontend, frontend-shared, frontend-embedでverbatimModuleSyntaxを有効化

import { someVar, SomeType } from '@/somewhere.js';

// TSコンパイラ的にはOKだが、統一のためこれはLintにより禁止
import { someVar, type SomeType } from '@/somewhere.js';

// これが正解
import { someVar } from '@/somewhere.js';
import type { SomeType } from '@/somewhere.js';

になる

Why

Fix #14113

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 17.51825% with 452 lines in your changes missing coverage. Please review.

Project coverage is 18.81%. Comparing base (a3d236c) to head (b1f7574).
Report is 587 commits behind head on develop.

Files with missing lines Patch % Lines
...ckages/frontend/src/components/MkNoteMediaGrid.vue 0.00% 35 Missing ⚠️
packages/frontend/src/components/grid/MkGrid.vue 0.00% 11 Missing ⚠️
...ackages/frontend/src/components/grid/grid-utils.ts 0.00% 8 Missing ⚠️
...ges/admin/custom-emojis-manager.local.register.vue 0.00% 7 Missing ⚠️
...ackages/frontend/src/widgets/WidgetAiscriptApp.vue 0.00% 7 Missing ⚠️
packages/frontend/src/components/grid/cell.ts 0.00% 6 Missing ⚠️
packages/frontend/src/components/grid/column.ts 0.00% 6 Missing ⚠️
...d/src/pages/admin/custom-emojis-manager.remote.vue 0.00% 6 Missing ⚠️
packages/frontend/src/pages/flash/flash.vue 0.00% 6 Missing ⚠️
packages/frontend/src/pages/scratchpad.vue 0.00% 6 Missing ⚠️
... and 184 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15323       +/-   ##
============================================
- Coverage    41.74%   18.81%   -22.94%     
============================================
  Files         1549      766      -783     
  Lines       196555   111337    -85218     
  Branches      2767     1234     -1533     
============================================
- Hits         82055    20947    -61108     
+ Misses      113939    89801    -24138     
- Partials       561      589       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review January 21, 2025 14:02
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.0 milestone Jan 28, 2025
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@mi-gh-maintainer mi-gh-maintainer bot merged commit c548ec9 into misskey-dev:develop Feb 5, 2025
23 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the refactor-verbatim-fe-1 branch February 5, 2025 10:03
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Feb 7, 2025
* wip

* wip

* wip

* wip

* revert unnecessary changes

* wip

* refactor(frontend): enforce verbatimModuleSyntax

* fix

* refactor(frontend-shared): enforce verbatimModuleSyntax

* wip

* refactor(frontend-embed): enforce verbatimModuleSyntax

* enforce consistent-type-imports

* fix lint config

* attemt to fix ci

* fix lint

* fix

* fix

* fix
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Mar 1, 2025
* wip

* wip

* wip

* wip

* revert unnecessary changes

* wip

* refactor(frontend): enforce verbatimModuleSyntax

* fix

* refactor(frontend-shared): enforce verbatimModuleSyntax

* wip

* refactor(frontend-embed): enforce verbatimModuleSyntax

* enforce consistent-type-imports

* fix lint config

* attemt to fix ci

* fix lint

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

refactor: verbatimModuleSyntax を導入する
1 participant