Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正 #15069

Merged

Conversation

sakuhanight
Copy link
Contributor

@sakuhanight sakuhanight commented Nov 28, 2024

What

ローカルかどうかの判定でutilityService.isUriLocalを使用していない箇所があったため修正しました。

Why

Fix #13540
自ホスト:example.com
リモート:example.community.net

のような時に、リモートからの受信時に同一ホストからの要求として判定され、エラーを返してしまうようです。
参考:
MisskeyIO#508

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.96%. Comparing base (a3d236c) to head (2958ccc).
Report is 652 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/backend/src/core/RemoteUserResolveService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15069      +/-   ##
===========================================
- Coverage    41.74%   39.96%   -1.78%     
===========================================
  Files         1549     1563      +14     
  Lines       196555   197746    +1191     
  Branches      2767     3634     +867     
===========================================
- Hits         82055    79033    -3022     
- Misses      113939   118108    +4169     
- Partials       561      605      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tai-cha tai-cha requested a review from syuilo January 17, 2025 23:32
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 7, 2025
@mi-gh-maintainer mi-gh-maintainer bot merged commit 39c487e into misskey-dev:develop Feb 26, 2025
32 checks passed
Copy link

Thank you 🙏

harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 26, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正

* fix(test backend): RelayServiceでUtilityServiceを使う
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Mar 1, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正

* fix(test backend): RelayServiceでUtilityServiceを使う
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Mar 1, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正

* fix(test backend): RelayServiceでUtilityServiceを使う
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 6, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正

* fix(test backend): RelayServiceでUtilityServiceを使う
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
3 participants