-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正 #15069
Merged
mi-gh-maintainer
merged 2 commits into
misskey-dev:develop
from
sakuhanight:misskey-dev/bugfix/13540
Feb 26, 2025
Merged
fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正 #15069
mi-gh-maintainer
merged 2 commits into
misskey-dev:develop
from
sakuhanight:misskey-dev/bugfix/13540
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
このPRによるapi.jsonの差分 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15069 +/- ##
===========================================
- Coverage 41.74% 39.96% -1.78%
===========================================
Files 1549 1563 +14
Lines 196555 197746 +1191
Branches 2767 3634 +867
===========================================
- Hits 82055 79033 -3022
- Misses 113939 118108 +4169
- Partials 561 605 +44 ☔ View full report in Codecov by Sentry. |
tai-cha
approved these changes
Jan 17, 2025
Thank you 🙏 |
harumaki2000
pushed a commit
to harumaki2000/misskey-layp
that referenced
this pull request
Feb 26, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正 * fix(test backend): RelayServiceでUtilityServiceを使う
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Mar 1, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正 * fix(test backend): RelayServiceでUtilityServiceを使う
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Mar 1, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正 * fix(test backend): RelayServiceでUtilityServiceを使う
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Mar 6, 2025
* fix(backend): ローカル判定でisUriLocalを使用していない箇所を修正 * fix(test backend): RelayServiceでUtilityServiceを使う
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ローカルかどうかの判定でutilityService.isUriLocalを使用していない箇所があったため修正しました。
Why
Fix #13540
自ホスト:example.com
リモート:example.community.net
のような時に、リモートからの受信時に同一ホストからの要求として判定され、エラーを返してしまうようです。
参考:
MisskeyIO#508
Additional info (optional)
Checklist