enhance(frontend): アンテナ、リスト等の名前をdeckのカラム名のデフォルト値にするように #13992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13992 +/- ##
========================================
Coverage 18.81% 18.82%
========================================
Files 766 766
Lines 111341 111400 +59
Branches 1234 1234
========================================
+ Hits 20951 20966 +15
- Misses 89801 89845 +44
Partials 589 589 ☔ View full report in Codecov by Sentry. |
|
lintがあかんかも |
|
dockleに気を取られて気づいてなかったですありがとうございます |
|
直しました(fix on saveが切れてた) |
|
Conflict解消 |
|
既に名前が指定されている場合でもデフォルト値用の名前取得のためだけにリクエストが発火されるのが無駄かもしれない（もしくはわたしが何か見逃してる…？） |
たしかにそうですね。nameがnull or emptyのときのみにしたほうが良いですね |
|
不要な場合には取得しないようにしました。 |
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Jan 28, 2025
commit a28ab48 Author: anatawa12 <anatawa12@icloud.com> Date: Thu Jan 9 11:02:25 2025 +0900 docs: fix changelog commit 212a2d8 Author: anatawa12 <anatawa12@icloud.com> Date: Thu Jan 9 10:50:26 2025 +0900 chore: チャンネルについては投稿でも使用されてる channel 変数を使用するように commit e173d2b Author: anatawa12 <anatawa12@icloud.com> Date: Thu Jan 9 10:48:54 2025 +0900 chore: カラム名が指定されている場合にはチャンネル名を取得しないように commit 6209947 Merge: c4c3c86 13439e0 Author: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Wed Jan 8 21:13:54 2025 +0900 Merge branch 'develop' into deck-default-name commit c4c3c86 Merge: cda207f 89841e4 Author: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Thu Sep 26 13:31:29 2024 +0900 Merge branch 'develop' into deck-default-name commit cda207f Merge: a805a27 8b4933c Author: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com> Date: Wed Jul 17 19:39:59 2024 +0900 Merge branch 'develop' into deck-default-name commit a805a27 Merge: eeb1d73 b8b4dc5 Author: syuilo <4439005+syuilo@users.noreply.github.com> Date: Sat Jun 22 19:45:39 2024 +0900 Merge branch 'develop' into deck-default-name commit eeb1d73 Author: anatawa12 <anatawa12@icloud.com> Date: Fri Jun 14 15:27:16 2024 +0900 lint: fix commit 063cd34 Author: anatawa12 <anatawa12@icloud.com> Date: Fri Jun 14 12:13:35 2024 +0900 docs: アンテナ、リスト等の名前をカラム名のデフォルト値にするように commit 90efe12 Author: anatawa12 <anatawa12@icloud.com> Date: Fri Jun 14 12:10:33 2024 +0900 feat: アンテナ、リスト等の名前をカラム名のデフォルト値にするように commit 452a8ed Author: anatawa12 <anatawa12@icloud.com> Date: Fri Jun 14 10:42:15 2024 +0900 refactor: remove type errors from deck.vue and deck-store.ts
5 tasks
kakkokari-gtyih
approved these changes
Feb 5, 2025
kakkokari-gtyih
changed the title
mi-gh-maintainer
bot
merged commit 607bf60
into
misskey-dev:develop
8 of 9 checks passed
|
Thank you 🙏 |
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Feb 7, 2025
…3992) * refactor: remove type errors from deck.vue and deck-store.ts * feat: アンテナ、リスト等の名前をカラム名のデフォルト値にするように * docs: アンテナ、リスト等の名前をカラム名のデフォルト値にするように * lint: fix * chore: カラム名が指定されている場合にはチャンネル名を取得しないように * chore: チャンネルについては投稿でも使用されてる channel 変数を使用するように * docs: fix changelog --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com> Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Mar 1, 2025
…3992) * refactor: remove type errors from deck.vue and deck-store.ts * feat: アンテナ、リスト等の名前をカラム名のデフォルト値にするように * docs: アンテナ、リスト等の名前をカラム名のデフォルト値にするように * lint: fix * chore: カラム名が指定されている場合にはチャンネル名を取得しないように * chore: チャンネルについては投稿でも使用されてる channel 変数を使用するように * docs: fix changelog --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com> Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11077
Why
Additional info (optional)
Checklist