Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(frontend): 管理画面の連合でサーバーサイレンスが出るように #12292

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

atsu1125
Copy link
Contributor

@atsu1125 atsu1125 commented Nov 9, 2023

What

Fix: #12031

Additional info (optional)

tested on my local environment

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 9, 2023
@atsu1125 atsu1125 force-pushed the fix-server-silence-adminpage branch from 067753a to 9c180ca Compare November 9, 2023 12:24
@atsu1125 atsu1125 marked this pull request as ready for review November 9, 2023 12:25
@atsu1125 atsu1125 changed the title Fix(frontend): サーバーサイレンス Fix(frontend): 管理画面の連合でサーバーサイレンスが出るように Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2cac3d) 78.86% compared to head (9c180ca) 78.84%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12292      +/-   ##
===========================================
- Coverage    78.86%   78.84%   -0.03%     
===========================================
  Files          946      944       -2     
  Lines       102065   101895     -170     
  Branches      8235     8243       +8     
===========================================
- Hits         80496    80338     -158     
+ Misses       21569    21557      -12     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 6cc0685 into misskey-dev:develop Nov 15, 2023
@syuilo
Copy link
Member

syuilo commented Nov 15, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants