Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDH private key serialization #243

Closed
palainp opened this issue Aug 20, 2024 · 1 comment · Fixed by #244
Closed

ECDH private key serialization #243

palainp opened this issue Aug 20, 2024 · 1 comment · Fixed by #244
Labels
enhancement New feature or request

Comments

@palainp
Copy link
Member

palainp commented Aug 20, 2024

Dear devs,
First of all thank you for this great library :)
In order to perform some local tests, I've needed to export (as a string) the ECDH priv/pub keys. So far, the library uses a secret that I haven't managed to export due to my lack of internal understanding :(
Is this (serialising the ECDH secret) something that makes sense and that it would be possible to write?
Best.
@hannesm
Copy link
Member

hannesm commented Aug 20, 2024

Thanks for your request. Indeed it would make sense to provide, similar to secret_of_octets, a function secret_to_octets in the ECDH module.

@hannesm hannesm added the enhancement New feature or request label Aug 20, 2024
@hannesm hannesm mentioned this issue Aug 20, 2024
Merged
hannesm added a commit to hannesm/opam-repository that referenced this issue Aug 20, 2024
@hannesm
[new release] mirage-crypto (9 packages) (1.1.0)
12f8b25 
CHANGES:

* FEATURE mirage-crypto-ec: provide Dh.secret_to_octets (requested in mirage/mirage-crypto#243 by
  @palainp, implemented by @hannesm mirage/mirage-crypto#244)
* mirage-crypto: fix CCM implementation, discovered while porting TLS to
  mirage-crypto 1.0.0 (@hannesm @dinosaure @reynir mirage/mirage-crypto#242)
@hannesm hannesm mentioned this issue Aug 20, 2024
Merged
avsm pushed a commit to avsm/opam-repository that referenced this issue Sep 5, 2024
@hannesm @avsm
[new release] mirage-crypto (9 packages) (1.1.0)
7370d6b 
CHANGES:

* FEATURE mirage-crypto-ec: provide Dh.secret_to_octets (requested in mirage/mirage-crypto#243 by
  @palainp, implemented by @hannesm mirage/mirage-crypto#244)
* mirage-crypto: fix CCM implementation, discovered while porting TLS to
  mirage-crypto 1.0.0 (@hannesm @dinosaure @reynir mirage/mirage-crypto#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mirage-crypto-ec: provide Dh.secret_to_octets hannesm/mirage-crypto
2 participants
@hannesm @palainp