Code

Roy/mempool#43

Code

Merged

royster57 merged 153 commits intomastermintlayer/mintlayer-core:masterfrom roy/mempoolmintlayer/mintlayer-core:roy/mempoolCopy head branch name to clipboardAug 3, 2022

+3,410-169

Commits

Commits on Aug 3, 2022

• Implement Sum trait for Amount

  royster57

  committed
  3589f7d

  Copy full SHA for 3589f7d

• Make Transaction errors thiserror

  royster57

  committed
  7d01158

  Copy full SHA for 7d01158

• Conversion from Amount to underlying u128 type

  royster57

  committed
  e315416

  Copy full SHA for e315416

• Basic Mempool Functionality

  royster57

  committed
  b612cdb

  Copy full SHA for b612cdb

• Move get outpoint value (Test pass)

  royster57

  committed
  35930a2

  Copy full SHA for 35930a2

• Order TxMempoolEntry by Hash, not Fee

  royster57

  committed
  40cf3a0

  Copy full SHA for 40cf3a0

• Fix DFS in unconfirmed ancestors_search

  royster57

  committed
  4444a86

  Copy full SHA for 4444a86

• Allow multiple txs with the same fee

  royster57

  committed
  82e3adf

  Copy full SHA for 82e3adf

• Refactor fee calculation

  royster57

  committed
  736cd4b

  Copy full SHA for 736cd4b

• Support txs with prescribed fees in tests

  royster57

  committed
  76e2d11

  Copy full SHA for 76e2d11

• Refactor TxMempoolEntry to make it unit-testable

  royster57

  committed
  5f6b788

  Copy full SHA for 5f6b788

• Add unit test for TxMempoolEntry

  royster57

  committed
  4f17792

  Copy full SHA for 4f17792

• Added unit test of TxMempoolEntry DFS

  royster57

  committed
  da02748

  Copy full SHA for da02748

• Refactor test utilityfunction tx_spend_input

  royster57

  committed
  eb59292

  Copy full SHA for eb59292

• replacement fee higher than original in unit test

  royster57

  committed
  b93eb87

  Copy full SHA for b93eb87

• Refactor call to is_replaceable in validation

  royster57

  committed
  7514284

  Copy full SHA for 7514284

• Add children to TxMempoolEntry

  royster57

  committed
  b77fb9a

  Copy full SHA for b77fb9a

• Need to figure out how to update parents

  royster57

  committed
  94667e7

  Copy full SHA for 94667e7

• Check that replacement tx pays more than conflict

  royster57

  committed
  476d2e4

  Copy full SHA for 476d2e4

• Add TODO to test tx_replace_child

  royster57

  committed
  a7c619c

  Copy full SHA for a7c619c

• Use H256 instead of Rc to reference entries in the mempool

  royster57

  committed
  4b26371

  Copy full SHA for 4b26371

• Getters for parents and children

  royster57

  committed
  150c9bd

  Copy full SHA for 150c9bd

• Add convenience method TxMempoolEntry::tx_id

  royster57

  committed
  5ffaa81

  Copy full SHA for 5ffaa81

• Refactor test tx_replace_child

  royster57

  committed
  787200e

  Copy full SHA for 787200e

• Expand tx_replace test

  royster57

  committed
  de77505

  Copy full SHA for de77505

• Move TxMepoolEntry next to impl

  royster57

  committed
  2b502e9

  Copy full SHA for 2b502e9

• Support count_with_descendants in TxMempoolEntry

  royster57

  committed
  ba417d6

  Copy full SHA for ba417d6

• Validate number of potential replacements

  royster57

  committed
  c5bab45

  Copy full SHA for c5bab45

• Rename 'get_parents' to 'unconfirmed_parents'

  royster57

  committed
  5ca71c9

  Copy full SHA for 5ca71c9

• Refactor parent update

  royster57

  committed
  f58473f

  Copy full SHA for f58473f

• Refactor ancestor count update

  royster57

  committed
  8f84402

  Copy full SHA for 8f84402

• Refactor marking outpoints as spent

  royster57

  committed
  98e8912

  Copy full SHA for 98e8912

• Remove local variable in add_tx

  royster57

  committed
  dcbc97b

  Copy full SHA for dcbc97b

• Make ReplacementFeeLowerThanOriginal error more descriptive

  royster57

  committed
  f2d69b0

  Copy full SHA for f2d69b0

• Fixed tx_spend_inputs

  royster57

  committed
  9f7499d

  Copy full SHA for 9f7499d

• Fix tx_replace_child test

  royster57

  committed
  9495d19

  Copy full SHA for 9495d19

• Refactor, expand, and rename tx_mempool_entry test

  royster57

  committed
  29db54c

  Copy full SHA for 29db54c

• fee member of TxGenerator does not need to be an option

  royster57

  committed
  d1253b9

  Copy full SHA for d1253b9

• Move MAX_BIP125_REPLACEMENT_CANDIDATES to module scope, for testing

  royster57

  committed
  0eb6ec9

  Copy full SHA for 0eb6ec9

• BIP125 max replacements test

  royster57

  committed
  232f9b0

  Copy full SHA for 232f9b0

• Refactor rbf checks into separate function

  royster57

  committed
  d6cf6c6

  Copy full SHA for d6cf6c6

• Refactor tx_spend_several_inputs

  royster57

  committed
  ee5ab37

  Copy full SHA for ee5ab37

• ChainState trait inherits Debug

  royster57

  committed
  ccf59f3

  Copy full SHA for ccf59f3

• Validation - Replacing Tx spends no new unconfirmed outputs

  royster57

  committed
  d4af46a

  Copy full SHA for d4af46a

• Clarity: Renaming and Comments

  royster57

  committed
  ea0de8e

  Copy full SHA for ea0de8e

• Validation: Replacement Tx pays more than conflicts together with their

  Show description for d6f518a
  royster57

  committed
  d6f518a

  Copy full SHA for d6f518a

• Test pays_more_than_conflicts_with_descendants

  royster57

  committed
  99e3564

  Copy full SHA for 99e3564

• derive(Debug) for test struct ValuedOutPoint

  royster57

  committed
  bcb0577

  Copy full SHA for bcb0577

• Add comment and reorder RBF validation calls

  royster57

  committed
  dce5337

  Copy full SHA for dce5337

• pays_more_than_conflicts_with_descendant returns total fee of conflicts and descendants

  royster57

  committed
  0bb2585

  Copy full SHA for 0bb2585

• Validation: replacement tx pays for its bandwidth

  royster57

  committed
  3c4641b

  Copy full SHA for 3c4641b

• Accomodate for relay fee checks in older tests

  royster57

  committed
  78fd4f5

  Copy full SHA for 78fd4f5

• Refactor TxGenerator: builder pattern for num_inputs, num_outputs

  royster57

  committed
  5c20791

  Copy full SHA for 5c20791

• TxGenerator: builder pattern for replaceability flag

  royster57

  committed
  194f4eb

  Copy full SHA for 194f4eb

• Remove outdated comments

  royster57

  committed
  cfe46ac

  Copy full SHA for cfe46ac

• wip delete TxGenerator::new and rename TxGenerator::new_with_unconfirmed to TxGenerator::new (this makes the tx_replace test fail because it is badly written)

  royster57

  committed
  342f073

  Copy full SHA for 342f073

• Make test_replace_tx use tx_spend_input instead of TxGenerator

  royster57

  committed
  d09cf9d

  Copy full SHA for d09cf9d

• Rename MempoolError to simply Error within the context of the crate

  royster57

  committed
  592801c

  Copy full SHA for 592801c

• Bug Fix: move rbf checks out of conflict loop

  royster57

  committed
  80d370a

  Copy full SHA for 80d370a

• Refactor rbf_checks

  royster57

  committed
  93dbbe1

  Copy full SHA for 93dbbe1

• Mempool: Add comment

  royster57

  committed
  b6f19b9

  Copy full SHA for b6f19b9

• Add function get_relay_fee

  royster57

  committed
  423be74

  Copy full SHA for 423be74

• Validation: minimum_relay_fees

  royster57

  committed
  2b5bcf6

  Copy full SHA for 2b5bcf6

• TESTS: accomodate for minimum relay fee check

  royster57

  committed
  a6008e4

  Copy full SHA for a6008e4

• TESTS: Fix txs_sorted (compute fees properly)

  royster57

  committed
  7280e16

  Copy full SHA for 7280e16

• TxMempoolEntry: new types for Ancestors and Descendants

  royster57

  committed
  6d356da

  Copy full SHA for 6d356da

• More precise errors for tx fee computation

  royster57

  committed
  9984a49

  Copy full SHA for 9984a49

• Add pow function to amount

  royster57

  committed
  94f3795

  Copy full SHA for 94f3795

• Add finalize_tx and move entry creation into it

  royster57

  committed
  9fecf33

  Copy full SHA for 9fecf33

• Return conflicts from validation

  royster57

  committed
  dee73dc

  Copy full SHA for dee73dc

• Drop conflicts when adding validated tx to mempool

  royster57

  committed
  9c8de4a

  Copy full SHA for 9c8de4a

• TESTS: verify conflicts are removed

  royster57

  committed
  c999b3c

  Copy full SHA for c999b3c

• Fix bug in confirmed_outpoints

  royster57

  committed
  70a9da9

  Copy full SHA for 70a9da9

• replace expect with error when when fee higher than inputs

  royster57

  committed
  bd2145f

  Copy full SHA for bd2145f

• Replace expect calls with errors

  royster57

  committed
  49404a4

  Copy full SHA for 49404a4

• Increase min, max output values in unit tests to make more deterministic

  royster57

  committed
  86c6573

  Copy full SHA for 86c6573

• Rename ChainStateMock's members

  royster57

  committed
  17eb185

  Copy full SHA for 17eb185

• Implement Rolling Fee Rate and eviction of expired entries

  royster57

  committed
  190fcdb

  Copy full SHA for 190fcdb

• rename random_unspent_outpoint -> get_unspent_outpoint

  royster57

  committed
  51abf64

  Copy full SHA for 51abf64

• Make InsufficientFeesToRelay error more informative

  royster57

  committed
  ef14b0e

  Copy full SHA for ef14b0e

• TESTS: TxGenerator fee handling

  royster57

  committed
  a716afe

  Copy full SHA for a716afe

• TESTS: Add manual implementation of Ord for ValuedOutPoint so coin_pool is

  Show description for c660762
  royster57

  committed
  c660762

  Copy full SHA for c660762

• TESTS: infrastructure improvements

  royster57

  committed
  1c1cdab

  Copy full SHA for 1c1cdab

• real_size_tx test

  royster57

  committed
  7c85942

  Copy full SHA for 7c85942

• Add test for different_size_txs

  royster57

  committed
  772a4e7

  Copy full SHA for 772a4e7

• Replace println calls with logging

  royster57

  committed
  970661b

  Copy full SHA for 970661b

• Delete old TODOs and constant pertaining to mempool fullness

  royster57

  committed
  fbc3723

  Copy full SHA for fbc3723

• Use logging in mempool tests

  royster57

  committed
  63052f9

  Copy full SHA for 63052f9

• Improve test function generate_tx_outputs

  royster57

  committed
  6ce5bdd

  Copy full SHA for 6ce5bdd

• make unspend_outpoints a function

  royster57

  committed
  6425ada

  Copy full SHA for 6425ada

• derive Debug for Ancestors, Descendants, Conflicts

  royster57

  committed
  577ce24

  Copy full SHA for 577ce24

• Add fees_with_descendant field to TxMempoolEntry

  royster57

  committed
  f016eb4

  Copy full SHA for f016eb4

• Rename txs_by_fee -> txs_by_descendant_score

  royster57

  committed
  438eee8

  Copy full SHA for 438eee8

• new function update_ancestor_state

  royster57

  committed
  870a636

  Copy full SHA for 870a636

• Update fees_with_descendants field of ancestors when new entry is

  Show description for 136f300
  royster57

  committed
  136f300

  Copy full SHA for 136f300

• remove outdated TODO

  royster57

  committed
  6f2d69a

  Copy full SHA for 6f2d69a

• Introduce DescendantScore type and sort according to it

  royster57

  committed
  2d77727

  Copy full SHA for 2d77727

• Update descendant score index when an entry is dropped

  royster57

  committed
  80dd611

  Copy full SHA for 80dd611

• Refactor and rename udpate_ancestor_state -> update_ancestor_state_for_add

  royster57

  committed
  487ec7e

  Copy full SHA for 487ec7e

• Update ancestor state when entry is dropped

  royster57

  committed
  a30b7bd

  Copy full SHA for a30b7bd

• TESTS: descendant score

  royster57

  committed
  98125c2

  Copy full SHA for 98125c2

• TESTS: add test try_replace_irreplaceable

  royster57

  committed
  aa3e2af

  Copy full SHA for aa3e2af

• Refactor finalize_tx

  royster57

  committed
  7d1434c

  Copy full SHA for 7d1434c

• Proper error for descendant of expired transaction

  royster57

  committed
  e8cb3c4

  Copy full SHA for e8cb3c4

• TESTS: descendant of expired entry

  royster57

  committed
  e143936

  Copy full SHA for e143936

• TESTS: mempool full

  royster57

  committed
  027d82c

  Copy full SHA for 027d82c

• TESTS: no empty bags in descendant score index

  royster57

  committed
  7961096

  Copy full SHA for 7961096

• Mempool: Documentation

  royster57

  committed
  6136347

  Copy full SHA for 6136347

• Improve style in ancestor and descendant functions

  royster57

  committed
  b564d87

  Copy full SHA for b564d87

• Fix FeeRate calculations to consistently use tokens/kb and update

  Show description for 2cab6ce
  royster57

  committed
  2cab6ce

  Copy full SHA for 2cab6ce

• Remove Amount::random, which is no longer needed

  royster57

  committed
  c6f2cd5

  Copy full SHA for c6f2cd5

• TESTS Remove time measurements from different_size_txs

  royster57

  committed
  b4f6dc2

  Copy full SHA for b4f6dc2

• Use u128 as FeeRate's underlying type

  royster57

  committed
  61c9daa

  Copy full SHA for 61c9daa

• FeeRate multiply before divide in computing tokens_per_kb

  royster57

  committed
  b3d5a66

  Copy full SHA for b3d5a66

• Replace unwrap calls with expect

  royster57

  committed
  fe8020e

  Copy full SHA for fe8020e

• Fix tests that broke during rebase

  royster57

  committed
  7b1c815

  Copy full SHA for 7b1c815

• Move mempool tests to separate file

  royster57

  committed
  c02d1db

  Copy full SHA for c02d1db

• Create FeeRate from Amount rather than integer type

  royster57

  committed
  b054ca5

  Copy full SHA for b054ca5

• Rename tokens_per_kb field of FeeRate to atoms_per_kb

  royster57

  committed
  b0ffd64

  Copy full SHA for b0ffd64

• Style changes to newtype macro

  royster57

  committed
  0f0365d

  Copy full SHA for 0f0365d

• Use exp2 method in rolling fee rate calculation

  royster57

  committed
  3eba529

  Copy full SHA for 3eba529

• Use into_atoms to convert Amount to u128

  royster57

  committed
  0dbcac4

  Copy full SHA for 0dbcac4

• Update scale codec to 3.1

  royster57

  committed
  8fb0b6c

  Copy full SHA for 8fb0b6c

• Test sum of empty Amount vector

  royster57

  committed
  ac5e23c

  Copy full SHA for ac5e23c

• Clean up compute_fee

  royster57

  committed
  7170066

  Copy full SHA for 7170066

• Use saturating_sub when computing expired entries

  royster57

  committed
  c5fa3a2

  Copy full SHA for c5fa3a2

• Add test for FeeRate::div_up

  royster57

  committed
  07019c9

  Copy full SHA for 07019c9

• Add comment to time_lock_notes.txt

  royster57

  committed
  cd04ceb

  Copy full SHA for cd04ceb

• Use NonZeroU128 as FeeRate divisor

  royster57

  committed
  40c45b7

  Copy full SHA for 40c45b7

• Remove unnecessary static bounds

  royster57

  committed
  5eb09bc

  Copy full SHA for 5eb09bc

• Rename test one_ancestor_signal_is_enough

  royster57

  committed
  98e8e4a

  Copy full SHA for 98e8e4a

• Rename tokens_per_kb -> atoms_per_kb

  royster57

  committed
  b3b0244

  Copy full SHA for b3b0244

• Rename FeeRate::of_tx -> FeeRate::from_total_tx_fees

  royster57

  committed
  3585773

  Copy full SHA for 3585773

• Remove eprintln calls

  royster57

  committed
  122479f

  Copy full SHA for 122479f

• Use ensure macro

  royster57

  committed
  f99611e

  Copy full SHA for f99611e

• Fix indentation in newtype example

  royster57

  committed
  205b79e

  Copy full SHA for 205b79e

• Friendlier human-readable errors for mempool

  royster57

  committed
  491585d

  Copy full SHA for 491585d

• Use Id<Transaction> instead of H256 where possible

  royster57

  committed
  01f766c

  Copy full SHA for 01f766c

• Use ensure in mempool

  royster57

  committed
  168509f

  Copy full SHA for 168509f

• Use from attribute to generate conversion TxValidationError->MempoolError

  royster57

  committed
  56e4da2

  Copy full SHA for 56e4da2

• Suppress clippy float arithmetic warning

  royster57

  committed
  b98edf8

  Copy full SHA for b98edf8

• Make PartialEq, Ord implementations consistent for TxMempoolEntry

  royster57

  committed
  48d61d0

  Copy full SHA for 48d61d0

• Correct order of operations in feerate calculation

  royster57

  committed
  91947ce

  Copy full SHA for 91947ce

• Round up in fee computation

  royster57

  committed
  51fc129

  Copy full SHA for 51fc129

• Add documentation

  royster57

  committed
  7865336

  Copy full SHA for 7865336

• Fix test tx_too_big

  royster57

  committed
  b15c868

  Copy full SHA for b15c868

• Move test machinery to different submodule

  royster57

  committed
  c7fea8b

  Copy full SHA for c7fea8b

• Refactor drop_tx

  royster57

  committed
  895615e

  Copy full SHA for 895615e

• Improvements to FeeRate::div_up

  royster57

  committed
  bf2fae0

  Copy full SHA for bf2fae0

• Remove no longer needed assert

  royster57

  committed
  7de1ead

  Copy full SHA for 7de1ead

• FeeRate division used only in tests

  royster57

  committed
  919df10

  Copy full SHA for 919df10

• Mempool TODOs

  royster57

  committed
  bfa9325

  Copy full SHA for bfa9325

• Update deny.toml

  royster57

  committed
  a78b0cf

  Copy full SHA for a78b0cf