Filter not activated LPAs 2.0

[lukejolliffe]

Purpose

Change implementation of getUserLpas so only activated LPAs are recieved. This will then stop LPAs from being visible on the dashboard if they are not activated

Fixes UML-1697

Approach

Changing this getUserLPAs method means that we are changing functionality as little as possible. Everywhere that gets LPAs are most likely using this method and will now mirror the existing functionality.

Checklist

• I have performed a self-review of my own code
• [ ] I have added relevant logging with appropriate levels to my code
• [ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
• I have added tests to prove my work
• [ ] I have added welsh translation tags and updated translation files
• [ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
• [ ] The product team have tested these changes

[codecov]

Codecov Report

Merging #1064 (094916f) into master (148cda8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1064      +/-   ##
============================================
+ Coverage     91.50%   91.51%   +0.01%     
- Complexity     1372     1374       +2     
============================================
  Files           222      222              
  Lines          4190     4198       +8     
  Branches         22       22              
============================================
+ Hits           3834     3842       +8     
  Misses          356      356              

Impacted Files	Coverage Δ
...pi/app/src/App/src/Service/Lpa/LpaAlreadyAdded.php	100.00% <100.00%> (ø)
...ice-api/app/src/App/src/Service/Lpa/LpaService.php	98.00% <100.00%> (+0.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148cda8...094916f. Read the comment docs.

[cooperaj]

Code looks fine, I have a concern with implementation though in that altering a methods return based on boolean parameters is generally seen as bad practice as it can be avoided by restructuring the code itself.

The getAllForUser method is called in 2 locations so, although I appreciate the simplicity of this change, wanting to avoid wider scale changes is not a particularly relevant concern.

Happy to discuss.

[lukejolliffe]

Code looks fine, I have a concern with implementation though in that altering a methods return based on boolean parameters is generally seen as bad practice as it can be avoided by restructuring the code itself.

The getAllForUser method is called in 2 locations so, although I appreciate the simplicity of this change, wanting to avoid wider scale changes is not a particularly relevant concern.

Happy to discuss.

That's reasonable, I'll change it into two different methods

[lukejolliffe]

This PR is helped by ministryofjustice/opg-data-lpa#51 which will add a requested LPA to the users LPAs which will then either be shown on the dashboard or not depending on the state of this ticket