Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UML-2592 - Specify api ecs task role and operator as allowed roles #77

Merged
merged 2 commits into from
Aug 30, 2022
Merged

UML-2592 - Specify api ecs task role and operator as allowed roles #77

merged 2 commits into from
Aug 30, 2022

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Jul 20, 2022 •
edited by jamesrwarren
Loading

Purpose

Access policy for the api is too permissive in production for UaL

Approach

  • Specify the UaL api ecs task role for preproduction and production

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • I have updated documentation where relevant
  • I have added tests to prove my work
  • I have run the integration tests (results below)

@jamesrwarren jamesrwarren marked this pull request as ready for review August 17, 2022 11:30
@jamesrwarren jamesrwarren merged commit 5c6ca24 into main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukejolliffe lukejolliffe lukejolliffe approved these changes

@sixdaysandy sixdaysandy Awaiting requested review from sixdaysandy

@xaithe xaithe Awaiting requested review from xaithe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewpearce-digital @lukejolliffe @jamesrwarren