IN-316 make it talk to Sirius #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 29, 2020 09:29
Added in some stuff for building Sirius requests
env vars for tests
Experimenting with hypothesis for auto generating test cases
hide the tests that fail :D
forgot
reinstate coverage in ci missed requirement
lets get sirius forgot imports
Quick test to see if we can hit sirius, and what we get back when we do. All temporary
Allow access to secrets manager
linting i can't terraform blimey I really can't terraform I'm just gonna do it through the console
This now returns the same payload, added into integrations tests too. Can't actually run tests atm because something's not building, boo. one of these might work Just doing what this guy said: hashicorp/terraform#24527
jamesrwarren
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
OK it's kinda big but a lot of the
sirius_serviceis just copied from the docs api, then added some super basic handler functions to call Sirius.Amended integration tests to call this branch and behold the results below.
Approach
I added more tests for the
sirius_serviceusing hypothesis, which is a library that auto-generates test data based on function inputs. It did throw up a few edge cases, so it's not a direct copy from docs!This has been beefed up in preparation for making it a shared module.
The terraform DNS change came out of nowhere. It wouldn't build and gave me these errors:
Google provided this answer and I made it work, so 🤷
Learning
Checklist