Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IN-255 integration tests for existing API #2

Merged
merged 3 commits into from
Jul 28, 2020
Merged

IN-255 integration tests for existing API #2

merged 3 commits into from
Jul 28, 2020

Conversation

jmackown
Copy link
Contributor

@jmackown jmackown commented Jul 28, 2020 •
edited
Loading

Purpose

So we have something we can use to compare our version with

Approach

Super basic for now, happy path and 404 (id not found)

Learning

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • I have updated documentation where relevant
  • I have added tests to prove my work
  • I have run the integration tests (results below)
    image

Jennifer Mackown added 3 commits July 28, 2020 15:10
8b9a13b 
Integration tests that run against original collections api (dev)
4e58d9a 
pre-commit linting installed :D
e774ed3 
add tests to template
jamesrwarren
jamesrwarren approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@jamesrwarren jamesrwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's super cool

@jmackown jmackown merged commit f287613 into master Jul 28, 2020
@jmackown jmackown deleted the IN-255 branch July 28, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrwarren jamesrwarren jamesrwarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmackown @jamesrwarren