Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IN-320 import sirius service from codeartifact #17

Merged
merged 2 commits into from
Aug 26, 2020
Merged

IN-320 import sirius service from codeartifact #17

merged 2 commits into from
Aug 26, 2020

Conversation

jmackown
Copy link
Contributor

Purpose

Use central version of sirius_service from AWS CodeArtifact

Approach

  • Deleted files, refactored what broke
  • Updated docker things to work with the new package
  • Updated readmes, because I went for lunch in the middle and already forgot how to run everything

Learning

Never used a Makefile before

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • I have updated documentation where relevant
  • I have added tests to prove my work
  • I have run the integration tests (results below)

Jennifer Mackown added 2 commits August 25, 2020 10:49
* refactored a bit to make it use the opg-sirius-service package
* added a makefile for docker to make things easier to spin up
* updated readme with new instructions
@jmackown jmackown merged commit 83ca17a into master Aug 26, 2020
@jmackown jmackown deleted the IN-320 branch August 26, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants