Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IN-270 add some more basic pact support #13

Merged
merged 2 commits into from
Aug 17, 2020
Merged

IN-270 add some more basic pact support #13

merged 2 commits into from
Aug 17, 2020

Conversation

jamesrwarren
Copy link
Contributor

@jamesrwarren jamesrwarren commented Aug 13, 2020

Purpose

Creating a bit more boiler plate pact code for when I move this all into opg-data and added instructions and tested a local pact setup with the new repo.

Approach

Jen had done most of the owrk already with the local env setup so was straight forward once I got that working.

Learning

None yet though going to try and get this centralised now so maybe more difficulty incoming...

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • I have updated documentation where relevant
  • I have added tests to prove my work
  • I have run the integration tests (results below)

@jamesrwarren jamesrwarren merged commit 163df97 into master Aug 17, 2020
@jamesrwarren jamesrwarren deleted the IN-270 branch September 28, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants