IN-318 caching tests on routes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 13, 2020 11:27
Add some tests! Test the insert/get from redis cache Jim said so I'm sure I've fixed this once already and another Refactored sirius service into object so we can use config better. This was more work than I anticipated.... Big refactor of sirius service into a class to enable more detailed config little fixes for AWS wip passing test Add caching just for when sirius is not available Add some tests! Test the insert/get from redis cache I'm sure I've fixed this once already and another Refactored sirius service into object so we can use config better. This was more work than I anticipated.... Big refactor of sirius service into a class to enable more detailed config little fixes for AWS missed a test merge problems
Tidying up so local test stuff doesn't go up to AWS linting move sirius service out of api make sure all the integration tests pass missed a test
Tidy up test config for sirius service (make it independent)
jamesrwarren
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Alter the existing route tests to include cache scenarios
Bonus - added the redis details into env vars
Approach
Learning
Checklist
caching disabled:
caching enabled:
