fix: resolve optional paths and packages #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously removed in #927
colinrotherham
force-pushed
the
sass-load-paths
branch
from
f7e9c5d to
8a5b17e
Compare
ehtabrizi
approved these changes
Feb 26, 2025
|
🎉 This PR is included in version 3.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two regressions identified from documentation
We should aim to release these to fix accidental breaking changes:
Ensure optional
peerDependenciesare still installedInstalling with npm does not list
moment(alongsidejquery) but it's required by GOV.UK Prototype Kit filtersEnsure
node_modulesis added to Sass load pathsResolving SCSS import paths is marked optional but removing
node_modulesbreaks GOV.UK Prototype Kit