Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core network services tags #9558

Merged
merged 1 commit into from
Mar 18, 2025
Merged

core network services tags #9558

merged 1 commit into from
Mar 18, 2025

Conversation

markgov
Copy link
Contributor

@markgov markgov commented Mar 17, 2025

A reference to the issue / Description of it

as part of Add default tags to terraform providers across the modernisation platform
#1519 we are adding

How does this PR fix the problem?

This Pr add the default atgging to the provider files for core network services

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@markgov markgov requested a review from a team as a code owner March 17, 2025 13:21
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-network-services

Running Trivy in terraform/environments/core-network-services
2025-03-17T13:23:22Z INFO [vulndb] Need to update DB
2025-03-17T13:23:22Z INFO [vulndb] Downloading vulnerability DB...
2025-03-17T13:23:22Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-03-17T13:23:24Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-03-17T13:23:24Z INFO [vuln] Vulnerability scanning is enabled
2025-03-17T13:23:24Z INFO [misconfig] Misconfiguration scanning is enabled
2025-03-17T13:23:24Z INFO [misconfig] Need to update the built-in checks
2025-03-17T13:23:24Z INFO [misconfig] Downloading the built-in checks...
163.77 KiB / 163.77 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-03-17T13:23:24Z INFO [secret] Secret scanning is enabled
2025-03-17T13:23:24Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-03-17T13:23:24Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-03-17T13:23:25Z INFO [terraform scanner] Scanning root module file_path="."
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table.external_inspection_in" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_in" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_out" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.live_data" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.non_live_data" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_cloudwatch_metric_alarm.ddos_attack_application_public_hosted_zone" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2025-03-17T13:23:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_shield_protection.application_public_hosted_zone" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand dynamic block. block="module.stream_firewall_logs.aws_kinesis_firehose_delivery_stream.firehose" err="1 error occurred:\n\t* invalid for-each in aws_kinesis_firehose_delivery_stream.firehose.dynamic.http_endpoint_configuration block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand dynamic block. block="module.stream_firewall_logs.aws_kinesis_firehose_delivery_stream.firehose" err="1 error occurred:\n\t* invalid for-each in aws_kinesis_firehose_delivery_stream.firehose.dynamic.http_endpoint_configuration block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_flow_log.s3" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.inspection" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.public" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.inspection" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.public" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:187"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:187"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:281"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:281"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:379"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:379"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2025-03-17T13:23:28Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2025-03-17T13:23:29Z INFO Number of language-specific files num=1
2025-03-17T13:23:29Z INFO [gomod] Detecting vulnerabilities...
2025-03-17T13:23:29Z INFO Detected config files num=7
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-network-services

*****************************

Running Checkov in terraform/environments/core-network-services
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2025-03-17 13:23:32,021 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/terraform-aws-observability-platform-tenant?ref=fbbe5c8282786bcc0a00c969fe598e14f12eea9b:None (for external modules, the --download-external-modules flag is required)
2025-03-17 13:23:32,021 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-chatbot?ref=73280f80ce8a4557cec3a76ee56eb913452ca9aa:None (for external modules, the --download-external-modules flag is required)
2025-03-17 13:23:32,022 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=cebe39c438390ffb5355827ec9469cfe9b09c22c:None (for external modules, the --download-external-modules flag is required)
2025-03-17 13:23:32,022 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
2025-03-17 13:23:35,036 [MainThread  ] [WARNI]  Failed to find context for resource.aws_flow_log.s3["${var.flow_log_s3_destination_arn}"]
2025-03-17 13:23:35,036 [MainThread  ] [WARNI]  Failed to find context for resource.aws_flow_log.s3["${var.flow_log_s3_destination_arn}"]
terraform scan results:

Passed checks: 277, Failed checks: 0, Skipped checks: 156


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/core-network-services

*****************************

Running tflint in terraform/environments/core-network-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/core-network-services

*****************************

Running Trivy in terraform/environments/core-network-services
2025-03-17T13:23:22Z	INFO	[vulndb] Need to update DB
2025-03-17T13:23:22Z	INFO	[vulndb] Downloading vulnerability DB...
2025-03-17T13:23:22Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-03-17T13:23:24Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-03-17T13:23:24Z	INFO	[vuln] Vulnerability scanning is enabled
2025-03-17T13:23:24Z	INFO	[misconfig] Misconfiguration scanning is enabled
2025-03-17T13:23:24Z	INFO	[misconfig] Need to update the built-in checks
2025-03-17T13:23:24Z	INFO	[misconfig] Downloading the built-in checks...
163.77 KiB / 163.77 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-03-17T13:23:24Z	INFO	[secret] Secret scanning is enabled
2025-03-17T13:23:24Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-03-17T13:23:24Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-03-17T13:23:25Z	INFO	[terraform scanner] Scanning root module	file_path="."
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table.external_inspection_in" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_in" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_out" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.live_data" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.non_live_data" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_cloudwatch_metric_alarm.ddos_attack_application_public_hosted_zone" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2025-03-17T13:23:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_shield_protection.application_public_hosted_zone" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="module.stream_firewall_logs.aws_kinesis_firehose_delivery_stream.firehose" err="1 error occurred:\n\t* invalid for-each in aws_kinesis_firehose_delivery_stream.firehose.dynamic.http_endpoint_configuration block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="module.stream_firewall_logs.aws_kinesis_firehose_delivery_stream.firehose" err="1 error occurred:\n\t* invalid for-each in aws_kinesis_firehose_delivery_stream.firehose.dynamic.http_endpoint_configuration block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_flow_log.s3" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.inspection" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.public" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.inspection" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.public" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2025-03-17T13:23:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:185"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:279"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:377"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:187"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:187"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:281"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:281"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:379"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:379"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2025-03-17T13:23:28Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2025-03-17T13:23:29Z	INFO	Number of language-specific files	num=1
2025-03-17T13:23:29Z	INFO	[gomod] Detecting vulnerabilities...
2025-03-17T13:23:29Z	INFO	Detected config files	num=7
trivy_exitcode=0

@github-actions GitHub Actions
Copy link
Contributor

Terraform Plan Summary

core-network-services-production
Plan: 0 to add, 21 to change, 0 to destroy.

@markgov markgov added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 595a283 Mar 18, 2025
6 checks passed
@markgov markgov deleted the tags/core-network-services branch March 18, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASTRobinson ASTRobinson ASTRobinson approved these changes

Assignees
No one assigned
Labels
core networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markgov @ASTRobinson