-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update provider to modernisation-secrets-read
and add modernisation-secrets-read
provider
#9526
Conversation
…isation account role
Terraform Plan Summarycore-vpc-test |
Terraform Plan Summarycore-vpc-development |
Terraform Plan Summarycore-vpc-preproduction |
Terraform Plan Summarycore-vpc-production |
Terraform Plan Summarycore-logging-production |
Terraform Plan Summarycore-security-production |
Terraform Plan Summarycore-network-services-production |
Terraform Plan Summarycore-shared-services-production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed this PR. Each account has a new provider added that calls the modernisation-account-limited-read-member-access` role and this provider is used by the environment_management data call.
A reference to the issue / Description of it
Recently, we created separate GitHub Actions roles for development and test accounts. In the current setup (a PR will be raised soon), an issue arose when running Member Environments workflow —secrets could not be accessed from the Modernisation Platform (MP) account due to the OIDC connection pointing to each member account. This resulted in failures to retrieve the necessary secrets. #8590
How does this PR fix the problem?
To resolve this issue, we have added a provider to assume a role in the MP account that has the necessary permissions to read the secrets. This ensures that secrets are accessed from the MP account regardless of the active OIDC connection in the Member account.
How has this been tested?
Tested Manually and also tested on Member Environment workflow
Deployment Plan / Instructions
Will this deployment impact the platform and / or services on it?
{Please write here}
Checklist (check
x
in[ ]
of list items)Additional comments (if any)
{Please write here}