Revert "LGA-785 - Adding Education and Discrimination categories to LAALAA" #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sldblog
reviewed
Sep 5, 2019
| { | ||
| "fields": { | ||
| "civil": true, | ||
| "code": "EDU" |
There was a problem hiding this comment.
What do you think about keeping changes in the seed fixtures?
It is still useful to populate these entries on our environments where we don't have uploads -- until we can add a "seed upload".
There was a problem hiding this comment.
In other words, I think it's enough to revert the migration.
|
Nice find. 👏 |
sldblog
approved these changes
Sep 5, 2019
sldblog
deleted the
revert-132-feature/LGA-785_education-and-discrimination-categories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #132
Seems like the CSV upload clears / populates the categories
See
https://github.com/ministryofjustice/laa-legal-adviser-api/blob/master/laalaa/apps/advisers/tasks.py#L55
and
https://github.com/ministryofjustice/laa-legal-adviser-api/blob/master/laalaa/apps/advisers/tasks.py#L264
This means that categories should be managed through the providers upload rather than in code.
This leaves the question of why have fixtures / seed data when they are cleared and repopulated on import. This needs to be investigated separately of this revert