Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCMSPUI-379 Implement GetClientDetails #151

Merged
merged 53 commits into from
Feb 25, 2025

Conversation

JamieBriggs-MoJ
Copy link
Contributor

There is a wider piece of work in Civil Billing and Payments which involves recreating SOA calls as views in the EBS API. One of the pieces which has been completed is the new view which replaces the client search called XXCCMS_GET_CLIENT_DETAILS_V.

As part of the work for this ticket, a new endpoint needs creating which returns client data using the new XXCCMS_GET_CLIENT_DETAILS_V view.

Jamie Briggs added 28 commits January 30, 2025 14:37
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
… for notification search

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…itional_notification_search_filters

# Conflicts:
#	data-service/src/main/java/uk/gov/laa/ccms/data/repository/specification/NotificationSpecification.java
… use Oracle-Free instead of embedded H2 DB

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…ation endpoint and added Notification schema for holding more data

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…actions

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…resentation layer

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…ation endpoint

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…ification.yml

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
@JamieBriggs-MoJ JamieBriggs-MoJ self-assigned this Feb 11, 2025
…gation.

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Jamie Briggs added 10 commits February 12, 2025 17:35
…ry/ccmspui-379_implement_get_client_details
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
… and checkstyle still needs rectifying.

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…rth instead of current surname to replicate SOA API

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…ailsMapperImplTest

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
# Conflicts:
#	data-api/open-api-specification.yml
#	data-service/src/integrationTest/java/uk/gov/laa/ccms/data/repository/NotificationSearchRepositoryIntegrationTest.java
#	data-service/src/integrationTest/resources/sql/get_notif_info_create_schema.sql
#	data-service/src/main/java/uk/gov/laa/ccms/data/entity/NotificationInfo.java
#	data-service/src/main/java/uk/gov/laa/ccms/data/mapper/NotificationMapper.java
#	data-service/src/main/java/uk/gov/laa/ccms/data/mapper/NotificationsMapper.java
#	data-service/src/main/java/uk/gov/laa/ccms/data/repository/NotificationSearchRepository.java
#	data-service/src/test/java/uk/gov/laa/ccms/data/mapper/NotificationMapperImplTest.java
#	data-service/src/test/java/uk/gov/laa/ccms/data/mapper/NotificationsMapperImplTest.java
…ailsMapperImplTest

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one main comment around the repositories, happy to discuss.

Jamie Briggs added 4 commits February 19, 2025 12:43
… "addCondition" methods to clean up inherited classes

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…he search functionality and utilize the JPA Specification class

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…iaBuilder implementation

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments

Jamie Briggs added 7 commits February 20, 2025 11:32
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…eatures

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…hreads, and added completable futures on BaseEntityManagerRepository

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamieBriggs-MoJ JamieBriggs-MoJ merged commit 634ae4b into main Feb 25, 2025
2 checks passed
@JamieBriggs-MoJ JamieBriggs-MoJ deleted the story/ccmspui-379_implement_get_client_details branch February 25, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants