CCMSPUI-529: Updated view and repository for Notification search #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 30, 2025 14:37
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
… for notification search Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
|
This PR will effect the view notification functionality due to now missing the attachments and notes from the notification search. This PR should not be merged until get notification has been implemented CCMSPUI-553, CCMSPUI-530 to avoid breaking the view notification portion of PUI UI. |
added 5 commits
February 3, 2025 16:17
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…itional_notification_search_filters # Conflicts: # data-service/src/main/java/uk/gov/laa/ccms/data/repository/specification/NotificationSpecification.java
… use Oracle-Free instead of embedded H2 DB Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
JamieBriggs-MoJ
commented
Feb 6, 2025
| @Mapping(target = "assignDate", source = "dateAssigned") | ||
| @Mapping(target = "providerCaseReferenceNumber", source = "providerCaseReference") | ||
| @Mapping(target = "caseReferenceNumber", source = "lscCaseRefReference") | ||
| @Mapping(target = "notificationType", source = "actionNotificationInd") | ||
| @Mapping(target = "notificationOpenIndicator", source = "isOpen") |
There was a problem hiding this comment.
@farrell-m This annotation was missing from the initial implementation, so it should map the open indicator now.
|
Closing PR as changes are included as part of #147. |
JamieBriggs-MoJ
deleted the
story/ccmspui-529_additional_notification_search_filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial view for searching notifications also pulled back notes, documents etc. This PR updates the Notification Entity to use the new view created which does not include all of this additional bloat information.
Also included in this PR is the transition from using JPA repositories to use
EntityManagerfor more optimised search results.Also included in this PR is the tweaking of some filters to ignore case.