Fix to TransactionStatus entity #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
January 20, 2025 16:31
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…ind actual client transactions. Updated tests to correlate with this. Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
# Conflicts: # data-service/src/main/java/uk/gov/laa/ccms/data/controller/NotificationsController.java
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…for case transactions Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
# Conflicts: # data-service/src/integrationTest/java/uk/gov/laa/ccms/data/repository/TransactionStatusRepositoryIntegrationTest.java # data-service/src/main/java/uk/gov/laa/ccms/data/controller/ClientsController.java # data-service/src/main/java/uk/gov/laa/ccms/data/repository/TransactionStatusRepository.java # data-service/src/main/java/uk/gov/laa/ccms/data/service/ClientService.java # data-service/src/test/java/uk/gov/laa/ccms/data/controller/ClientsControllerTest.java # data-service/src/test/java/uk/gov/laa/ccms/data/service/ClientServiceTest.java
…ut different process names. Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
# Conflicts: # data-service/src/main/java/uk/gov/laa/ccms/data/repository/TransactionStatusRepository.java
…ut different process names. Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where sometimes a transaction may have the same request ID and timestamp. This was fine if you ran a query such as this:
However this led to confusion with hibernate when getting statuses with this specific request ID resulting in returning the wrong row.
Have added
processNameto the composite key to return correct results.