CCMSPUI-379 Made request params in client search mandatory

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>

data-api/open-api-specification.yml

@@ -1078,16 +1078,19 @@ paths:
       parameters:
         - name: 'first-name'
           in: 'query'
+          required: true
           schema:
             type: 'string'
             example: 'john'
         - name: 'surname'
           in: 'query'
+          required: true
           schema:
             type: 'string'
             example: 'smith'
         - name: 'date-of-birth'
           in: 'query'
+          required: true
           schema:
             type: 'string'
             example: "2017-01-01"

data-service/src/test/java/uk/gov/laa/ccms/data/controller/ClientsControllerTest.java

@@ -115,7 +115,7 @@ void shouldReturnData() throws Exception {
 
       // Then
       String jsonContent = objectMapper.writeValueAsString(details);
-      mockMvc.perform(get("/clients"))
+      mockMvc.perform(get("/clients?first-name=first&surname=last&date-of-birth=2010-01-01"))
           .andDo(print())
           .andExpect(status().isOk())
           .andExpect(content().json(jsonContent));
@@ -125,9 +125,37 @@ void shouldReturnData() throws Exception {
     @DisplayName("Should return not found")
     void shouldReturnNotFound() throws Exception {
       // Then
-      mockMvc.perform(get("/clients"))
+      mockMvc.perform(get("/clients?first-name=first&surname=last&date-of-birth=2010-01-01"))
           .andDo(print())
           .andExpect(status().isNotFound());
     }
+
+
+    @Test
+    @DisplayName("Should return bad request when missing first name")
+    void shouldReturnBadRequestWhenMissingFirstName() throws Exception {
+      // Then
+      mockMvc.perform(get("/clients?surname=last&date-of-birth=2010-01-01"))
+          .andDo(print())
+          .andExpect(status().isBadRequest());
+    }
+
+    @Test
+    @DisplayName("Should return bad request when missing surname")
+    void shouldReturnBadRequestWhenMissingSurname() throws Exception {
+      // Then
+      mockMvc.perform(get("/clients?first-name=first&date-of-birth=2010-01-01"))
+          .andDo(print())
+          .andExpect(status().isBadRequest());
+    }
+
+    @Test
+    @DisplayName("Should return bad request when missing date of birth")
+    void shouldReturnBadRequestWhenMissingDateOfBirth() throws Exception {
+      // Then
+      mockMvc.perform(get("/clients?first-name=firstsurname=last"))
+          .andDo(print())
+          .andExpect(status().isBadRequest());
+    }
   }
 }