generated from ministryofjustice/hmpps-template-kotlin
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DST-18168 initial pdf generation #4
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcus-bcl
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! We'll need to add the Helm config for deploying and linking up for Gotenberg too - but that's one for next week.
src/main/kotlin/uk/gov/justice/digital/hmpps/breachnoticeapi/config/GotenbergConfig.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/uk/gov/justice/digital/hmpps/breachnoticeapi/controller/BreachNoticeController.kt
Outdated
Show resolved
Hide resolved
marcus-bcl
added a commit
that referenced
this pull request
Feb 28, 2025
* DT-1101 Copy in probation-offender-events * DT-1101 Switch out all project specific words for place holders * DT-1101 Add todo * DT-1101 Remove reference to old project name * DT-1101 Rename file name to match class name * Comment out preprod/prod deploy jobs from circleci workflow (#1) * DT-1101: ⬆️ Upgrade kotlin and other minor tweaks (#2) * DT-1116: ✨ Add in version info, banner etc. (#3) * DT-1116: ✨ Stab at rename script (#4) * DT-1116: ✨ Stab at rename script * DT-1116: ✨ Perform rename of kotlin files too * DT-1137: ⬆️ Update to latest spring boot (#5) * DT-1167: ⬆️ Bump plugin to fix owasp vuln (#6) * DT-1182: 🚑 Switch back to default ingress (#7) * add up-to-date k8s/helm labels (#8) * trialing two options for a github action to be run straight after deployment from template (#9) * fix typo (#10) * update github actions workflows and README (#11) * DT-1431: ⬆️ Upgrade to latest gradle plugin / spring boot etc. (#12) * Make rename script compatible with bsd version of sed (#13) * Update to latest hmpps orb version (#14) * Update to latest hmpps orb version * Update to latest hmpps orb version * DT-1546: ⬆️ Application insights v3 (#15) * DT-1546: 🔊 bump logging level to match pre 3.0 agent (#16) * DT-1597: ⬆️ Suppress owasp vuln and upgrade to kotlin 1.4.30 (#17) * DT-1597: ⬆️ Suppress owasp vuln and upgrade to kotlin 1.4.30 * DT-1597: ⬆️ Also bump kotlin version in build file * Speed up deployment time (#18) * DT-1638 useLatestVersions (#19) * DT-1685: 🔨 Remove fetching AWS secrets (#20) * Use generic-service chart instead of project specific one (#21) * DT-1659: 🔨 Remove helm copying secrets from AWS (#22) * Updated helm_deploy README (#24) * Updated helm_deploy README * Update to latest generic-service chart (#25) * Update to latest generic-service chart (#26) * Add new veracode scan for schedueled workflow (#27) * DT-1738 - veracode pipeline scan job (#28) * DT-1829 Upgrades (#30) * DT-1829 useLatestVersions * DT-1829 upgrade kotlin spring version * DT-1858: 🐛 Suppress netty false positive (#31) * DT-1893: ✨ Upgrade to java 16 (#32) * DT-1893: ✨ Specify jvm target and circle use java 16 (#33) * 📃 Change license file (#34) * DT-1627: 📄 Update license (#35) * DT-1987: ⬆️ Upgrade to kotlin 1.5 (#36) * DT-1627: 📄 Update license with correct year (#37) * DT-2012 - remove veracode from kotlin projects, java 16 and kotlin 1.5 not supported yet. (#38) * Use generic-promethues-alerts chart (#39) * DT-2050: ⬆️ Upgrade to app insights 3.1.0 (#40) * pgp DT 2070 spring boot upgrade (#41) * DT-2070: ⬆️ Upgrade to spring boot 2.5.0 and kotlin 1.5.10 * DT-2070: ⬆️ Upgrade to 3.3.0 of gradle plugin * DT-2107 - enable veracode policy scan, java 16 now supported (#42) * DT-2099 - move alerts for tech team projects to tech team slack channel (#43) * DT-2173: Sample health requests (#44) * Fix default alertmanager receiver (#45) * DT-2166 - add trivy image scanning job (#47) * DT-2166 - add trivy image scanning job * Add slack channel parameters * DT-2253: ⬆️ Upgrade spring boot / kotlin (#49) * Revert "DT-2253: ⬆️ Upgrade spring boot / kotlin" (#50) This reverts commit 00f0ac5. * DT-2255 - update orb to latest and redeploy to new namespace (#51) * DT-2255 - update orb to latest and redeploy to new namespace * Update to latest generic-service chart * Update README.md. (#52) * Update README.md. * Minor fixes, README.md, delete unused github workflow (#53) * DT-2260 - update to latest circleci orb and chart dependencies (#54) * DT-2253: ⬆️ Upgrade spring boot / kotlin without spring security (#55) * DT-2287: ⬆️ Upgrade spring security (#56) * DT-2366: ⬆️ Upgrade to latest spring boot and kotlin (#57) * DT-2366: ⬆️ Remove beta tag as plugin now released (#58) * DT-2457: 🐛 Suppress false positive for lang tag (#59) * DT-2297 - Veracode - switch to daily pipeline scan (results in circleci), and weekly policy scan (upload to veracode portal). (#60) * DT-2297- randomise timing of circleci security workflow due to rate limiting at veracode. (#61) * DT-2477: ⬆<fe0f> Upgrade to latest spring boot and kotlin (#62) * Add "apt-get -y upgrade" to Dockerfile - pull down OS patches faster (#63) * DT-2510: 🔧 Add upgrade to Dockerfiles and upgrade libraries (#64) * DT-2510: 🔧 Add upgrade to Dockerfiles and upgrade libraries * DT-2510: 🔧 Also fix java / kotlin jdk versions * DT-2574: ⬆️ Suppress false positives by upgrading dependencies (#65) * DT-2619: ⬆️ Upgrading to Spring Boot 2.5.5 to resolve CVE (#66) * DT-2702: 🔨 Use new generic service configuration (#67) * DT-2783: ⬆️ Upgrading to Spring Boot 2.5.6 to resolve CVE (#68) * DT-2767: ⬆️ Switch to java 17 (#70) * DT-2814: 🐛 Fix cron timings for veracode (#71) * DT-2849: ⬆️ Switch to latest plugin to remove jcenter and upgrade app insights (#72) * DT-2796: 🔨 Migrate dev to live context (#73) * DT-2989: add trivyignore for log4j false positive (#75) * DT-2990: 🔒️ Bump log4j to fix false positives (#76) * DT-2990: 🔒️ Bump log4j and netty (#77) * DT-2952: ⬆️ Upgrade to latest spring boot and kotlin (#79) * DT-2952: ⬆️ Upgrade to latest spring boot and kotlin * DT-2952: 🐛 Switch to different info path after upgrade * CVSL-337: Update spring boot plugin to remove owasp/trivy failures overnight. (#80) * Remove "live1" cluster references (#81) The IPs for the live1 and live clusters are all the same: https://user-guide.cloud-platform.service.justice.gov.uk/documentation/other-topics/ip-filtering.html#live-cluster However, it's a bit misleading to reference the old cluster, hence this change * SDI-45: ⬆️ Bump dependencies to latest (#83) * SDI-45: 🔨 Add in preprod and prod and tidy (#84) * SDI-60: 🔨 Add global protect and petty france to allowlists (#85) * SDI-71: 🔒️ Bump versions for security issues (#86) * Update to using gradle-spring-boot v 4.1.0 (#94) Co-authored-by: Steve Wilson <steve.wilson@digtial.justice.gov.uk> * Updated circleci config to use hmpps orb v 3.14 (#95) Co-authored-by: Steve Wilson <steve.wilson@digtial.justice.gov.uk> * HAAR-299: ⬆️ Upgrade to hmpps.gradle-spring-boot (#97) * ⚡️ Always run server-class JVMs inside our containers (#98) * HAAR-350: ⬆️ Upgrade to hmpps.gradle-spring-boot (#99) * HAAR-382: ⬆️ Upgrade to hmpps.gradle-spring-boot - 4.1.6 (#100) * HEAT-3: ⬆️ Switch to multi architecture builds to build for arm64 too (#101) * HEAT-4: ⬆️ upgrade gradle-spring-boot plugin to 4.1.7 (#102) * HEAT-4: ⬆️ upgrade gradle-spring-boot plugin to 4.1.7 * HEAT-4: ⬆️ Upgrade to hmpps.gradle-spring-boot - 4.1.7 * HEAT-6: ⬆️ Upgrade to hmpps.gradle-spring-boot - 4.2.0 (#103) * HAAR-504: ⬆️ Upgrade to hmpps.gradle-spring-boot - 4.2.1 (#104) * HAAR-528: ⬆️ upgrade gradle-spring-boot plugin to 4.2.2 (#106) * HAAR-528: ⬆️ upgrade gradle-spring-boot plugin to 4.2.3 (#107) * HAAR-597: ⬆️ upgrade gradle-spring-boot plugin to 4.3.2 (#109) * HAAR-646: ⬆️ upgrade gradle-spring-boot plugin to 4.3.3 (#110) * HEAT-12: use eclipse-temurin docker image instead of openjdk (#111) * HEAT-12: use eclipse-temurin docker image instead of openjdk * HEAT-12: Kotlin doesn't require JDK to build, unlike Java, so use JRE instead * Bump to latest hmpps-helm-charts and use CloudPlatform 1.2 ingress controller (#112) * SDI-296 Upgrade Gradle plugin and temporarily turn off veracode scan (#113) * HAAR-714: ⬆️ Upgrade to springboot 2.7.3 via gradle-spring-boot plugin 4.4.2 (#114) * HAAR-816: ⬆️ Upgrade plugin to latest (#115) to suppress snakeyaml vulnerability * HAAR-849: ⬆️ upgrade gradle-spring-boot plugin to 4.5.1 (#116) * SDI-409: ⬆️ Grab latest spring boot gradle plugin (#117) * Add readme badges (#118) * HAAR-935: ⬆️ update circleci orb version for setup_remote_docker (#119) * HAAR-935: ⬆️ update circleci orb version for setup_remote_docker * HAAR-935: ⬆️ enable veracode pipeline scan * HAAR-949: ⬆️ upgrade gradle-spring-boot plugin to 4.5.5 (#120) * upgrade plugins, upgrade orb, set deployment timeout (#121) * Add JIRA notifications (#122) * SDI-438: ⬆️ Upgrade to latest for spring security 5.7.5 (#123) * SDI-434: ⬆️ Upgrade to java 19 (#124) * SDI-434: ⬆️ Upgrade to java 19 * SDI-434: ✨ Allow to float to major version of hmpps orb * HAAR-1036: ⬆️ update to spring boot plugin 4.7.1 and update gradle to 7.6 (#125) * HAAR-1069: ⬆️ update to spring boot plugin 4.7.4 (#126) * Configure Renovate (#127) * Add renovate.json * HEAT-52: source Renovate config from shared HMPPS repo --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Neil Mendum <neil.mendum@digital.justice.gov.uk> * Update all non major Gradle dependencies (#132) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update hmpps orb to v7 (#134) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Helm release generic-service to v2.4.0 (#131) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Helm release generic-prometheus-alerts to v1.2.4 (#130) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update peter-evans/create-pull-request action to v4 (#135) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/checkout action to v3 (#133) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * HEAT-52: reduce the size of the PR body by specifying prBodyTemplate (#139) This should help with GitHub integration in Slack * Update plugin uk.gov.justice.hmpps.gradle-spring-boot to v4.8.3 (#138) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency gradle to v8 (#140) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert "Update dependency gradle to v8 (#140)" (#142) This reverts commit 89d8dd3. * Update Helm release generic-service to v2.5.0 (#144) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * HAAR-1218: ⬆️ update to spring boot plugin 4.8.4 (#146) * Update all non major Gradle dependencies (#149) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency gradle to v7.6.1 (#143) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Use Kotlin 1.8.10 to match the DPS Spring Boot Gradle Plugin (#152) See https://github.com/ministryofjustice/dps-gradle-spring-boot/blob/main/release-notes/4.8.6.md#attempted-upgrade-to-kotlin-1820 for issues with Kotlin 1.8.20 * Update Helm release generic-service to v2.6.2 (#154) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * SDIT-405: ⬆️ Upgrade to spring boot 3 (#156) * SDIT-405: ⬆️ Upgrade to spring boot 3 * SDIT-405: 🐛 Fix failing ktlint * SDIT-405: ♻️ Remove unnecessary milestone dependency * Update Helm release generic-prometheus-alerts to v1.3.2 (#157) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Include JDK tag to fix gradle_owasp_dependency_check job (#159) It failed https://app.circleci.com/pipelines/github/ministryofjustice/hmpps-template-kotlin/1240/workflows/22be3d2e-9a67-469b-a7c0-e6975d92bac6/jobs/2971 * Update peter-evans/create-pull-request action to v5 (#150) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update plugin uk.gov.justice.hmpps.gradle-spring-boot to v5.2.0 (#160) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update plugin org.jetbrains.kotlin.plugin.spring to v1.8.22 (#161) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency gradle to v8.2 (#163) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update all non major Gradle dependencies (#162) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * HAAR-1762: ⬆️ update to spring-boot-plugin-5.4.0 (#167) * HAAR-1762: ⬆️ update to spring-boot-plugin-5.4.0 * HAAR-1762: ⬆️ update gradle to 8.3 * SDIT-1060: ⬆️ Upgrade to java 20 (#169) * HEAT-106: add product id to info endpoint (#172) * HEAT-106: add product id to info endpoint * HEAT-106: update product id to not be null * HEAT-106: update test * HEAT-106: update product id to info endpoint * HEAT-106: remove unneeded productId from application.yml * HEAT-106: correct case for product-id * SDIT-575: 🐛 Change sampling to be 100% (#175) * SDIT-1116: ⬆️ Upgrade to latest spring boot etc (#176) * SDIT-1196: ⬆️ Upgrade to java 21 (#177) * Migrating project to use groups in allowlist (#179) * Updating generic service version to 2.8 * This PR migrates the project to use groups of IPs in their allowlist. By referring to groups to IP addresses, we can centralize the definition of groups of ip addresses. If these lists require changing in the future, we can change the definition once and future deploys across all services will automatically include these new IPs. 1 allowlist(s) have been detected that can be migrated. ## Allowlist: helm_deploy/hmpps-template-kotlin/values.yaml ### New Groups The effect of applying this PR is as follows: - The following groups will be applied: `internal` - The size of the allowlist defined in this file will change: `8 => 0 (8 removed)` ### Added IPs The new Group membership will result in the following IPs being added to your allowlist by applying this PR: Merging this PR should not result in any additional IP addresses being added to the allowlist. ### Removed IPs The following IPs have been identified as unnecessary and will be removed by applying this PR: - health-kick (35.177.252.195/32) * SDIT-1248: 🔨 Fix pushing JIRA deployment information (#180) * SDIT-1230: 💚 Change scan time so doesn't get rate limited (#181) * Requre user input when excucting rename script to ensure slack alert channels are set correctly. (#184) * Ensure product ID is set when bootstrapping new projects (#185) * HAAR-2154: update to spring boot plugin 5.10.1 (#187) * SDIT-1398: ⬆️ Upgrade spring boot and minor fixes (#188) * SDIT-1398: ✨ Also bump cache key and chart version (#189) * SDIT-1388: 🐛 Use latest plugin to get owasp working again (#190) * SDIT-1398: 🎨 Improve error handler (#191) * CRS-1803 corrected logging in exception handler (#193) * CRS-1803 corrected logging in exception handler * correct method name * HAAR-2281: update to spring boot plugin 5.15.2 (#195) * HAAR-2402: spring boot plugin 5.15.3 (#198) * HAAR-2402: update to spring boot plugin 5.15.3 * HAAR-2402: update helm generic-prometheus-alerts * HAAR-2536: ⬆️ update to spring-boot-plugin-5.15.6 (#201) * HAAR-2536: ⬆️ update to spring-boot-plugin-5.15.6 * HAAR-2356: update helm generic-service, generic-prometheus-alerts and gradle version * SDIT-1735: 🎨 Migrate sampling overrides (#204) * CDPS-765: Correcting README shields (#208) * SDIT-1788: ⬆️ Upgrade to latest spring boot etc. (#209) * Ignore kotlin build directory that’s moved in v2 compiler (#211) https://kotlinlang.org/docs/whatsnew20.html#new-directory-for-kotlin-data-in-gradle-projects * SDIT-1862: ⬆️ Upgrade to latest spring boot (#214) * SDIT-1340: 🔥 Remove version from health and logging (#215) * SDIT-1315: ✨ Add in secured endpoint (#216) * SDIT-1919: ⬆️ Upgrade to latest spring boot (#220) * SDIT-1315: ✨ Start to add in call out to other services (#221) * SDIT-1315: ✨ Add in missing url for secured endpoint (#222) * SDIT-1978: ⬆️ Upgrade to hmpps spring boot 6.0.3 (#223) * SDIT-1315: ✨ Add in call out to itself (#224) * SDIT-1315: ✨ Use new shared template namespace (#225) * SDIT-1315: 🎨 Improvements after code review (#226) * SDIT-1315: 🎨 More improvements after code review (#227) * HAAR-2942: ⬆️ update to spring-boot-plugin-6.0.4 (#228) * HAAR-2942: ⬆️ update to spring-boot-plugin-6.0.4 * HAAR-2942: update to hmpps-kotlin-spring-boot-starter:1.0.5 * HAAR-2942: update to spring-boot-plugin-6.0.4 * HAAR-2942: update to gradle.properties * SDIT-2009: 🧑💻 Add TODOs where code should be amended (#231) * SDIT-1315: ✨ Add docker compose instructions to template (#232) * SDIT-2009: 🔨 Fix rename script to work with new host name (#233) * SDIT-1316: ✨ Add in openapi docs (#235) * SDIT-1316: ✨ Add in openapi docs * SDIT-1316: ✨ Fix security requirements and test * SDIT-1316: ✨ Fix build gradle formatting * SDIT-1315: 📝 Copy readme changes from typescript project (#236) * SDIT-1315: ✨ Sort out package name as doesn't need to contain hmpps prefix (#238) * SDIT-1315: ✨ Sort out package name as doesn't need to contain hmpps prefix * SDIT-1315: 📝 Correct readme after PR review * SDIT-2049: ⬆️ Upgrade to hmpps spring boot 6.0.6 for path directory traversal fix (#242) * Move security jobs from circleci to github actions (#243) * fix: remove workflow modifications from rename script (#248) This will ensure the rename process works - a separate PR will be needed to change the schedule manually. * HEAT-313 - implement Github workflows for test -> build -> deploy (#245) * Added documentation ref for creating new service in README.md (#250) * Removed circleci config update (#251) * Removed circleci config update * Update rename-project.bash Added manual steps message * HAAR-3341: ⬆️ update to spring-boot-plugin-6.0.9 (#253) * SDIT-2316: 🎨 Use separate app insights configuration secret (#254) * HAAR-3373: ⬆️ update to spring-boot-plugin-6.1.0 (#255) * remove rename, update to v2 and add workflows to github actions (#257) * Simplify main pipeline and add deploy env workflow. (#259) * HEAT-417 cancel existing workflows (#258) * add concurrency defaults * commenting is better * chore(deps): update ministryofjustice/hmpps-github-actions action to v2 (#256) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: james Hart <james.hart@digital.justice.gov.uk> * SECURIT_ALERTS_SLACK_CHANNEL_ID for security workflows (#260) * CDPS-1080: Update application.yml TODO comment (#262) * Update to be compatible with new terraform module https://github.com/ministryofjustice/cloud-platform-terraform-hmpps-template (#263) * SDIT-2561: ⬆️ Upgrade spring boot to 3.4.2 (#265) * SDIT-2561: ⬆️ Upgrade hmpps spring boot plugin to 7.7.1 (#266) * ktlintFormat + add services to validate workflow * Set java version * Remove unneeded services * Trigger CI --------- Co-authored-by: Mike Halma <mike.halma@digital.justice.gov.uk> Co-authored-by: Matt <34448412+mattops@users.noreply.github.com> Co-authored-by: petergphillips <peter@greenthistle.co.uk> Co-authored-by: Andrew Lee <1517745+andrewrlee@users.noreply.github.com> Co-authored-by: Mike Halma <58170926+mikehalmamoj@users.noreply.github.com> Co-authored-by: Chris Faulkner <58180863+chris-faulkner-mojdt@users.noreply.github.com> Co-authored-by: SimonMitchellMOJ <51327941+SimonMitchellMOJ@users.noreply.github.com> Co-authored-by: Jon Brighton <jonathan.brighton@digital.justice.gov.uk> Co-authored-by: Neil Mendum <nmendum@gmail.com> Co-authored-by: timharrison-moj <47779388+timharrison-moj@users.noreply.github.com> Co-authored-by: Dávid Lantos <david.lantos@digital.justice.gov.uk> Co-authored-by: Steven Wilson <steve.wilson@digital.justice.gov.uk> Co-authored-by: Steve Wilson <steve.wilson@digtial.justice.gov.uk> Co-authored-by: Dávid Lantos <david.lantos@gmail.com> Co-authored-by: Neil Mendum <neil.mendum@digital.justice.gov.uk> Co-authored-by: carlov20 <carlov20@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: carloveo-moj <144013256+carloveo-moj@users.noreply.github.com> Co-authored-by: petergphillips <5099053+petergphillips@users.noreply.github.com> Co-authored-by: Jon Brighton <brightonsbox@hotmail.com> Co-authored-by: ushkarev <ushkarev@users.noreply.github.com> Co-authored-by: Simon Mitchell <51327941+simon-mitchell@users.noreply.github.com> Co-authored-by: james Hart <james.hart@digital.justice.gov.uk> Co-authored-by: Sandhya1874 <39799075+Sandhya1874@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.