-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more contact options for ask a question #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds showing microsoft teams channels or team emails to direct questions to, where given
This comment was marked as outdated.
This comment was marked as outdated.
|
hjribeiro-moj
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #976
It makes possible surfacing different contact information for the Ask a question section in fmd. Two additional types of ways to ask a question have been added.
I have added three additional properties to our entity class in datahub library
Entity.custom_properties.further_information
where theFurtherInformation
class now has the properties:For teams looks like

For team email looks like

Where there are all three of the options present i opted not to display all of the contact info as this might be a bit confusing and make the screen very busy. I'm assuming most teams will have a preferred way to be contacted re questions about the data and will enter this for their contact property.
In the case all contact info is present the order of importance is Slack > Teams > team email
for balance here's what it would look like if we displayed everything we held (and we held all routes)
