Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more contact options for ask a question #992

Merged
merged 12 commits into from
Oct 30, 2024

Conversation

LavMatt
Copy link
Contributor

@LavMatt LavMatt commented Oct 28, 2024

PR for #976

It makes possible surfacing different contact information for the Ask a question section in fmd. Two additional types of ways to ask a question have been added.

  • Microsoft Team channel
  • Team email (not not be confused with ms teams)

I have added three additional properties to our entity class in datahub library Entity.custom_properties.further_information where the FurtherInformation class now has the properties:

  • dc_teams_channel_name
  • dc_teams_channel_url
  • dc_team_email

For teams looks like
image

For team email looks like
image

Where there are all three of the options present i opted not to display all of the contact info as this might be a bit confusing and make the screen very busy. I'm assuming most teams will have a preferred way to be contacted re questions about the data and will enter this for their contact property.

In the case all contact info is present the order of importance is Slack > Teams > team email

for balance here's what it would look like if we displayed everything we held (and we held all routes)
image

@LavMatt LavMatt changed the title Fmd 976 generalise ask a question feat: add more contact options for ask a question Oct 28, 2024
@LavMatt LavMatt marked this pull request as ready for review October 28, 2024 12:14
@LavMatt LavMatt requested a review from a team as a code owner October 28, 2024 12:14
@murdo-moj

This comment was marked as outdated.

@murdo-moj
Copy link
Contributor

image

@murdo-moj
Copy link
Contributor

murdo-moj commented Oct 29, 2024

  • I reduced the text somewhat to make the multiple contact channels look nicer.
  • Slack, teams and a team email all get listed as contact channels if they exist.
  • If none of those channels exist but there's an owner, direct the user to the owner
  • If no owner exists, the standard "Not provided." text is shown

Copy link
Contributor

@hjribeiro-moj hjribeiro-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murdo-moj murdo-moj merged commit 8be635d into main Oct 30, 2024
8 checks passed
@murdo-moj murdo-moj deleted the fmd-976-generalise-ask-a-question branch October 30, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants