fix(auth): ensure users are created using emails as returned from azure #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure was returning emails with cases that had changed and it broke user access
LavMatt
changed the title
weve removed the `normalize_email` method from our CustomUserManager this was causing issues when emails in users_customuser did not match emails returned from azure where `normalize_email` would lowercase the domain of an email
LavMatt
changed the title
MatMoore
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure was returning emails with cases that had changed and it broke user accessIt was our code changing emails before creating them as users and in some cases creating a key in the
users_customusertable that was different from what was being returned by azure