fix(accessibility): add entity type to details page titles #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is required so we can override the base title where more information is needed for accessibility the base template needs to be extended in the child for the override and having head included in base meant we could not override
adds in a title block to override the title in base by adding entity type to h1_value
murdo-moj
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes entity type appear on page title for accessibility needs
It required a slight refactor of the templates because having a separate head template in base meant we couldn't override the title value for details pages (templates need to be directly extended to have values overridden)- so now there is no head template and the contents of head is contained within base
Resolves #879