Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct labels for "Selected filters" panel #695

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Aug 21, 2024

We recently introduced a translation file just for english, so that all the messages are in one file. We have also changed some of the copy to make it more understandable to our users, e.g. Domain is now referred to as Subject area.

However, these labels weren't going through the translation system, so they didn't get affected by this change.

@MatMoore MatMoore requested a review from a team as a code owner August 21, 2024 09:13
@MatMoore MatMoore force-pushed the fix-another-domain-reference branch from f13ae07 to 1c19466 Compare August 21, 2024 09:16
@MatMoore MatMoore force-pushed the fix-another-domain-reference branch from 1c19466 to edeaecf Compare August 21, 2024 09:18
@MatMoore MatMoore merged commit e011227 into main Aug 21, 2024
6 of 7 checks passed
@MatMoore MatMoore deleted the fix-another-domain-reference branch August 21, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants