Update details page header and title #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
previously approved these changes
Jul 1, 2024
There was a problem hiding this comment.
LGTM, but I think we need another template change to show "Chart" in a tag next to the heading, as shown here https://www.figma.com/design/zTOVhHRnWfxRJqH6Gr8cIc/Catalogue-sketches?node-id=793-3088&t=K3kBX5AXprGH8Nrf-4
MatMoore
previously approved these changes
Jul 2, 2024
mitchdawson1982
force-pushed
the
dp-462-details-page-header-and-title
branch
from
e75488f to
aea8469
Compare
MatMoore
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h1_valuewith names of the underlying metadata object on the details page<stong>tags to denote the type of asset on the details pagebenchmark/test_exact_matches.pytestsChartmetadata for testing purposesget_chart_detailsresponse method