Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter container entities on dc_display_in_catalogue #509

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Jun 27, 2024

Resolves #435

I was unable to directly filter in the GraphQL query, as Datahub is ignoring the filter. As a workaround, we can filter in the python instead.

@MatMoore MatMoore requested a review from a team as a code owner June 27, 2024 14:22
Copy link

sentry-io bot commented Jun 27, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/datahub-client/data_platform_catalogue/client/datahub_client.py

Function Unhandled Issue
get_database_details ValidationError: 1 validation error for OwnerRef ...
Event Count: 12
get_database_details KeyError: 'total' /details/{result_type}/{urn}
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@MatMoore MatMoore marked this pull request as draft June 27, 2024 14:59
@MatMoore MatMoore marked this pull request as ready for review June 27, 2024 16:04
@LavMatt LavMatt merged commit 6d5365a into main Jun 28, 2024
4 of 5 checks passed
@LavMatt LavMatt deleted the filter-databases branch June 28, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update client's get_database_details() method to return only display tagged tables
2 participants