Homepage fixes #501
Merged
Homepage fixes #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fmj- prefix with app- This follows an unofficial convention followed by many other services, and makes it easier to lift and shift components. Also add missing links to logo.
LavMatt
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmj-prefix withapp-(this follows an unofficial convention followed by many other services, and makes it easier to lift and shift components)I also had a look at increasing the left/right padding of the masthead component (so that the padding is equal on all sides), but this doesn't work because the text inside needs to horizontally align with the text in the main body of the page, which uses govuk-width-container for the right/left margins.